feat(create-json-from-ts-function): log the creation of the typescrip…

…t file templates just like the
vespertilian · Jun 8, 2018 · e7d51d0 · e7d51d0
1 parent 902cafb
commit e7d51d0
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/...create-json-from-templates-and-zone-data/create-json-from-templates-and-zone-data.spec.ts b/...create-json-from-templates-and-zone-data/create-json-from-templates-and-zone-data.spec.ts
@@ -13,7 +13,7 @@ describe('.createJSONFromTemplatesAndZoneData', () => {
             .createSpy('createJSONFromHandlebarsTemplates');
 
         const createJSONFromTsFunctionSpy = jasmine
-            .createSpy('createJSONFromHandlebarsTemplates');
+            .createSpy('createJSONFromTsFunction');
 
         const getIANATzDataStub = jasmine.createSpy('getIANATzDataSpy')
             .and.returnValue(fakeIANAData());
@@ -25,9 +25,9 @@ describe('.createJSONFromTemplatesAndZoneData', () => {
             createJSONFromTsFunctionSpy
         );
 
-        // TODO update test to check createJSONFromTsFunctionSpy
-        // check default params
         expect(createJSONFromHandlebarsTemplatesSpy).toHaveBeenCalledTimes(1);
+        expect(createJSONFromTsFunctionSpy).toHaveBeenCalledTimes(1);
+
         const firstCallParams: ICreateJSONFromTemplatesParams =
             createJSONFromHandlebarsTemplatesSpy.calls.argsFor(0)[0];
 

diff --git a/src/create-json-from-templates-and-zone-data/create-json-from-templates-and-zone-data.ts b/src/create-json-from-templates-and-zone-data/create-json-from-templates-and-zone-data.ts
@@ -15,7 +15,6 @@ const defaultSettings: ICreateJSONSettings = {
     zoneFileNames: ['zone1970.tab']
 };
 
-
 export interface ICreateJSONFromTemplatesParams{
     templateFileNames: string [],
     extractedZoneData: IExtractedTimezoneData,
@@ -50,7 +49,6 @@ export async function createJSONFromTemplatesAndZoneData(
             saveDirectory
         });
 
-        // TODO test
         await _createJSONFromTsFunctions({
             templateFileNames: typescriptFiles,
             extractedZoneData,

diff --git a/src/create-json-from-ts-function/create-json-from-ts-function.spec.ts b/src/create-json-from-ts-function/create-json-from-ts-function.spec.ts
@@ -17,12 +17,21 @@ describe('.createJSONFromTsFunctions', () => {
             .createSpy('writeFileAsyncSpy');
 
         const ensureExistsAsync = jasmine.createSpy('ensureExists');
+        const logSpy = jasmine.createSpy('console.log');
 
-        await createJsonFromTsFunctions(params, writeFileAsyncStub, ensureExistsAsync);
+        await createJsonFromTsFunctions(
+            params,
+            writeFileAsyncStub,
+            ensureExistsAsync,
+            logSpy
+        );
 
         const fileWritePath = writeFileAsyncStub.calls.first().args[0];
         const jsonString = writeFileAsyncStub.calls.first().args[1].toString();
 
+        // logs file creation
+        expect(logSpy).toHaveBeenCalledWith('Creating JSON for: test.ts with foo-zone.tab');
+
         expect(fileWritePath).toEqual('dira/dirb/saveDirFoo/sample-data-1-foo-zone-file-a.json');
         expect(JSON.parse(jsonString)).toEqual({a: 1});
 

diff --git a/src/create-json-from-ts-function/create-json-from-ts-functions.ts b/src/create-json-from-ts-function/create-json-from-ts-functions.ts
@@ -13,9 +13,8 @@ export async function createJsonFromTsFunctions(
 ) {
     const {templateFileNames, extractedZoneData, templatesPath, zoneFileName, saveDirectory} = params;
 
-
-    // TODO log the files we are creating
     for(const filenamePath of params.templateFileNames) {
+        _log(`Creating JSON for: ${filenamePath} with ${zoneFileName}`);
         const fullFilePath = `${params.templatesPath}/${filenamePath}`;
         const fullFilePathWithoutExtension = fullFilePath.slice(0, fullFilePath.lastIndexOf('.'));