Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use switch space combine with match #5390

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Mar 8, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5263

Description:

The space id is set during runtime when using USE space, but the prop prune rule necessitates the space id to be present during the optimizer stage. This means that during the initial execution, all properties will be pruned.

How do you solve it?

Check validation context

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added the type/bug Type: something is unexpected label Mar 8, 2023
@Aiee Aiee requested review from czpmango and xtcyclist March 8, 2023 12:10
@Aiee Aiee added ready-for-testing PR: ready for the CI test ready for review labels Mar 8, 2023
@Aiee Aiee requested a review from jievince March 8, 2023 12:10
@xtcyclist xtcyclist merged commit 118e86d into vesoft-inc:master Mar 10, 2023
@Aiee Aiee deleted the fix-5263 branch March 10, 2023 03:03
jievince pushed a commit to jievince/nebula that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

result is incorrect if use + match, property is missing
3 participants