Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix heartbeat handling update old time #5271

Merged
merged 6 commits into from
Feb 1, 2023
Merged

fix heartbeat handling update old time #5271

merged 6 commits into from
Feb 1, 2023

Conversation

tangyuanzhang
Copy link
Contributor

critical27
critical27 previously approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~ LGTM, thx for the contribution again.

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Jan 31, 2023
pengweisong
pengweisong reviewed Jan 31, 2023
View reviewed changes
src/kvstore/raftex/RaftPart.cpp Outdated
@@ -1081,8 +1081,13 @@ void RaftPart::processAppendLogResponses(const AppendLogResponses& resps,
CHECK_EQ(lastLogId, lastCommitId);
committedLogId_ = lastCommitId;
committedLogTerm_ = lastCommitTerm;
lastMsgAcceptedCostMs_ = lastMsgSentDur_.elapsedInMSec();
lastMsgAcceptedTime_ = time::WallClock::fastNowInMilliSec();
auto nowCosMs = lastMsgSentDur_.elapsedInMSec();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowCostMs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accept

@critical27 critical27 merged commit afd6a4d into vesoft-inc:master Feb 1, 2023
@critical27
Copy link
Contributor

Thx again~~

@wey-gu wey-gu mentioned this pull request Feb 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengweisong pengweisong pengweisong approved these changes

@critical27 critical27 critical27 approved these changes

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangyuanzhang @critical27 @pengweisong @Sophie-Xie