Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern expression with same edge variable #5192

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Fix pattern expression with same edge variable #5192

merged 3 commits into from
Jan 5, 2023

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Jan 4, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

https://github.com/vesoft-inc/nebula-ent/issues/2060

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Jan 4, 2023
@Sophie-Xie Sophie-Xie requested review from codesigner and Shylock-Hg and removed request for codesigner and Shylock-Hg January 4, 2023 07:29
@Shylock-Hg
Copy link
Contributor

Add more test in feature/match/PathExprRefLocalVariable.feature

@czpmango czpmango force-pushed the fix/pattern-expr-with-same-edge branch 2 times, most recently from 7bbbbf7 to 61a8bdb Compare January 4, 2023 09:13
@czpmango
Copy link
Contributor Author

czpmango commented Jan 4, 2023

Add more test in feature/match/PathExprRefLocalVariable.feature

OKey.

Shylock-Hg
Shylock-Hg reviewed Jan 4, 2023
View reviewed changes
tests/tck/features/match/PathExpr.feature
@@ -50,22 +50,22 @@ Feature: Basic match
"""
MATCH (v:player) WITH (v)-[v]-() AS p RETURN p
"""
Then a SemanticError should be raised at runtime: Alias `v' should be Edge, but got type 'Node'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous error message is a bit ambiguous.

@czpmango czpmango force-pushed the fix/pattern-expr-with-same-edge branch from 78c3cf4 to 348fc5b Compare January 4, 2023 09:46
@xtcyclist xtcyclist force-pushed the fix/pattern-expr-with-same-edge branch from 348fc5b to 9746483 Compare January 5, 2023 01:50
xtcyclist
xtcyclist previously approved these changes Jan 5, 2023
View reviewed changes
@czpmango czpmango force-pushed the fix/pattern-expr-with-same-edge branch from 9746483 to 1730f97 Compare January 5, 2023 03:12
@Sophie-Xie Sophie-Xie merged commit 5a91e24 into vesoft-inc:master Jan 5, 2023
@wey-gu wey-gu mentioned this pull request Jan 7, 2023
Closed
Sophie-Xie pushed a commit that referenced this pull request Jan 28, 2023
@czpmango @Sophie-Xie
Fix pattern expression with same edge variable (#5192)
635f376 
* Fix pattern expression with same edge variable

add tck

fmt

* add tck
Sophie-Xie added a commit that referenced this pull request Jan 29, 2023
@Sophie-Xie @nevermore3
@jievince @HarrisChu @critical27 @yixinglu @caton-hpg @xtcyclist @cangfengzhs @czpmango @Aiee @liwenhui-soul @SuperYoko @codesigner @wey-gu @Shylock-Hg @pengweisong @wenhaocs @Shinji-IkariG
Cherry pick 3.4 (0101-0129) (#5280)
c48cbd1 
* optimize match node label (#5176)

* revert strange return (#5183)

Co-authored-by: Sophie <[email protected]>

* fix stderr  save error log (#5188)

* fix processor_test timeout (#5180)

* fix processor_test timeout

* ...

Co-authored-by: Yee <[email protected]>
Co-authored-by: Sophie <[email protected]>

* fix error code (#5186)

* rename the "test" space to "ngdata". (#5197)

* rename the "test" space to "ngdata".

* add ngdata

* Revise the usages of FATAL, DFATAL, LOG, DLOG. (#5181)

* Revise the usages of FATAL, DFATAL, LOG, DLOG.

* fix.

* revise dfatal.

* Meta upgrade (#5174)

* Meta upgrade
remove all fulltext index when upgrade from V3 to V3_4 because of refacting of
fulltext index

* fix bug

Co-authored-by: Sophie <[email protected]>

* Fix pattern expression with same edge variable (#5192)

* Fix pattern expression with same edge variable

add tck

fmt

* add tck

* Fix memory leak, remove toss gflag (#5204)

* remove toss gflag

* fix memory leak

* loose wait job finish time

Co-authored-by: Sophie <[email protected]>

* Add max_sessions_per_ip_per_user to default config file (#5207)

* minor bug for adminTaskManager (#5195)

* modify jobmanager ut (#5175)

* modify jobmanager ut

* add expired ut

* avoid recover expired job

* add ut

* address review

* move status

Co-authored-by: Sophie <[email protected]>

* Add more match test cases on paths. (#5189)

* improve memtracker, add missed check & remove unnecessary thenError&tryCatch check (#5199)

* [memtracker] check code run with memoery check on all works

refine code

all code memory checked

fix lint

refine code & fix build with gcc+sanitize

* fix build break

* fix lint

* refine code

* remove debug code

* fix test fail build with debug

* fix test fail build with debug

* restore commented test

* minor

* minor

* fix bug (#5214)

* fix bug

* fix bug

Co-authored-by: Doodle <[email protected]>

* handle rpc error task status (#5212)

Co-authored-by: Sophie <[email protected]>

* chore: community badges refined (#5202)

* chore: community badges refined

* Update README-CN.md

* Update README-CN.md

* Update README-CN.md

remove sifou and zhihu as aligned with the team

* update linkedin URL

Co-authored-by: Yee <[email protected]>

* Fix extend whtie space char. (#5213)

* Fix extend whtie space char.

* Format.

Co-authored-by: Sophie <[email protected]>

* Add lack tests of no role user. (#5196)

Co-authored-by: Yee <[email protected]>

* remove memtracker DLOG (#5224)

* Add tck cases for DDL (#5220)

* more TCK tests for variable pattern match clause (#5215)

* cleanup

* same src/dst for variable length pattern

* variable pattern in where clause

* variable scope tests in path pattern

* More tests

* More tests

Co-authored-by: jimingquan <[email protected]>

* Resumed the evaluation fo vertices in AttributeExpression (UTs included) (#5229)

* add memtracker flags to conf (#5231)

* add memtracker flags to conf

* typo

* refine

* refine

* add balance job type to filter when create backup (#5228)

* add more job type to filter when create backup

* log add job

* add log before acquire snapshot lock

Co-authored-by: Sophie <[email protected]>

* Fix update sessions when leader change happens (#5225)

* Fix udpate sessions when leader change happens

* Handle errors on the graph side

* Address comments

* Address comments

* fix match step range (#5216)

* use smart pointer change raw pointer

* fix error

* fix test error

* address comment

Co-authored-by: Sophie <[email protected]>

* Update response message when adding schema historically existed (#5227)

* update the error code and message for checking history schemas

* update tck

* update comment

* change to log error

* fix ddl tck

* increase wait time in schema.feature

Co-authored-by: Sophie <[email protected]>

* fix error code (#5233)

Co-authored-by: Sophie <[email protected]>

* print memory stats default to false (#5234)

* print memory stats default to false

* update conf

Co-authored-by: Sophie <[email protected]>

* fix bug of extract prop expr visitor (#5238)

* forbid invalid prop expr used in cypher (#5242)

* Fix mistake push down limit with skip. (#5241)

Co-authored-by: Sophie <[email protected]>

* fix delete fulltext index (#5239)

* fix delete fulltext index

* fix es delete error
1. remove get Rowreader if op is delete
2. delete es data when value is null

Co-authored-by: Sophie <[email protected]>

* Change the default value of session_reclaim_interval_secs to 60 seconds (#5246)

Co-authored-by: Sophie <[email protected]>

* Enhance attribute-accessing expression to ensure self-consistency (#5230)

* Revert "Remove all UNKNOWN_PROP as a type of null. (#4907)" (#5149)

This reverts commit aa62416.

Co-authored-by: Sophie <[email protected]>

* Enhance attribute-accessing expression to ensure self-consistency

Fix tck

Fix parser

small delete

Fix tck

tck fmt

fix ut

fix ut

Fix ut

Fix tck

Delete v.tag.prop check

Fix tck

Skip some tck cases related ngdata

add test case

Co-authored-by: Cheng Xuntao <[email protected]>
Co-authored-by: Sophie <[email protected]>

* fix ft index of fixed string (#5251)

Co-authored-by: Sophie <[email protected]>

* Add tck test (#5253)

* add allpath test

* add shortest path test case

* add subgraph test case

* add go test case

* add go test case

* Add more session tests (#5256)

Co-authored-by: Sophie <[email protected]>

* Revert "do not check term for leader info by default para" (#5266)

This reverts commit 593bffc.

* modify ft index default limit size (#5260)

* modify ft index default limit size

* fix test

Co-authored-by: Doodle <[email protected]>

* Test/yield (#5267)

* Add some tests about yield.

* Add more tests.

Co-authored-by: Sophie <[email protected]>

* Add another cert to test CA don't match. (#5247)

Co-authored-by: Sophie <[email protected]>

* fix baton miss reset in StorageJobExecutor (#5269)

* Report errors on where clauses in optional match queries. (#5273)

* [test case] Check DML cases (#5264)

* Check DML cases

* Add chinses char tests

Add more tests

Add mero delete edge tests

* Revert cases

* fix third party version in package.sh (#5281)

The dump_syms tool path should be match with third party version.

* Test/user (#5139)

* Add some tests about user management.

* Add tests about user roles.

* Format.

* Fix tck fixture name.

* Fix step name.

* Change step name.

---------

Co-authored-by: Sophie <[email protected]>

* fix https (#5283)

* fix memtracker bugs during stress test on graphd and storaged (#5276)

* fix memtracker bugs during stress test on graphd and storaged

* fix lint

* fix RocksEngine memory leak of raw pointer iter

* add ENABLE_MEMORY_TRACKER build option & support adaptive limit for MemoryTracker

* delete debug log

* refine log

* refine log

* fix build

* refine error log

* print warning if memtracker is off

* fix rocksdb leak by turn off memcheck

* refine synamic-self-adaptive

* fix cmake check

* minor

* minor

* minor

* minor

* minor

* refine double equel compare

---------

Co-authored-by: jimingquan <[email protected]>
Co-authored-by: jie.wang <[email protected]>
Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: Yee <[email protected]>
Co-authored-by: canon <[email protected]>
Co-authored-by: Cheng Xuntao <[email protected]>
Co-authored-by: hs.zhang <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: liwenhui-soul <[email protected]>
Co-authored-by: Alex Xing <[email protected]>
Co-authored-by: codesigner <[email protected]>
Co-authored-by: Wey Gu <[email protected]>
Co-authored-by: shylock <[email protected]>
Co-authored-by: pengwei.song <[email protected]>
Co-authored-by: haowen <[email protected]>
Co-authored-by: George <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@xtcyclist xtcyclist xtcyclist approved these changes

Assignees
No one assigned
Labels
cherry-pick-v3.4 ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czpmango @Shylock-Hg @xtcyclist @Sophie-Xie