Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate output column names of join #4965

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

jievince
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #4960

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince added ready-for-testing PR: ready for the CI test ready for review labels Nov 30, 2022
@jievince jievince requested review from Shylock-Hg and yixinglu and removed request for Shylock-Hg November 30, 2022 09:20
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some TCK cases, such as: MATCH .. MATCH ... RETURN *

@Shylock-Hg
Copy link
Contributor

Need UT of JoinExecutor.

@codecov-commenter
Copy link

Codecov Report

Base: 76.84% // Head: 76.90% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a914d80) compared to base (e1a0283).
Patch coverage: 95.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4965      +/-   ##
==========================================
+ Coverage   76.84%   76.90%   +0.05%     
==========================================
  Files        1101     1101              
  Lines       81205    81239      +34     
==========================================
+ Hits        62405    62479      +74     
+ Misses      18800    18760      -40     
Impacted Files Coverage Δ
src/graph/executor/query/InnerJoinExecutor.cpp 53.61% <ø> (-2.14%) ⬇️
src/graph/executor/query/InnerJoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/JoinExecutor.h 100.00% <ø> (ø)
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/graph/util/ExpressionUtils.cpp 94.51% <89.47%> (+0.23%) ⬆️
src/graph/executor/query/JoinExecutor.cpp 84.21% <100.00%> (+4.21%) ⬆️
src/graph/planner/plan/Query.cpp 72.68% <100.00%> (+4.49%) ⬆️
src/graph/context/Result.cpp 70.00% <0.00%> (-7.78%) ⬇️
src/graph/planner/match/StartVidFinder.cpp 87.50% <0.00%> (-5.84%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@Sophie-Xie Sophie-Xie merged commit 4731ed9 into vesoft-inc:master Dec 2, 2022
@jievince jievince deleted the fix-join-dup-colname branch December 2, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LeftJoin executor outputs the joined columns multi times
5 participants