-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicate output column names of join #4965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some TCK cases, such as: MATCH .. MATCH ... RETURN *
Need UT of JoinExecutor. |
Codecov ReportBase: 76.84% // Head: 76.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4965 +/- ##
==========================================
+ Coverage 76.84% 76.90% +0.05%
==========================================
Files 1101 1101
Lines 81205 81239 +34
==========================================
+ Hits 62405 62479 +74
+ Misses 18800 18760 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a914d80
to
3c3f552
Compare
3c3f552
to
8de5cbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #4960
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: