-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split experimental_feature flag #4728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efficient |
panda-sheep
approved these changes
Oct 14, 2022
wey-gu
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I created the issue before realizing your pr 🙃. The issue was aligned with @MuYiYong already. |
pengweisong
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
critical27
approved these changes
Oct 17, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 17, 2022
* split experimental_feature flag * eof
critical27
added a commit
that referenced
this pull request
Oct 17, 2022
* Fix aggregate expression type deduce (#4706) * fix aggregate expression type deduce add test case fix tck fix tck * fix ut * fix hdfs download command will always return succeeded (#4723) * remove rebuild index guard when job finished (#4722) * remove rebuild index guard when job finished * fix reenter problem Co-authored-by: Sophie <[email protected]> * split experimental_feature flag (#4728) * split experimental_feature flag * eof * forbid insert vertex when vertex_key flag is off (#4727) * forbid insert vertex when vertex_key flag is off * fix issue ent#1420 * fix test case * fix format Co-authored-by: Sophie <[email protected]> Co-authored-by: kyle.cao <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: Alex Xing <[email protected]>
foesa-yang
added
doc done
PR:the doc for this PR is done.
and removed
doc affected
PR: improvements or additions to documentation
labels
Oct 20, 2022
cr了代码,没做验证 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-v3.3
PR: need cherry-pick to this version
doc done
PR:the doc for this PR is done.
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4729
Description:
experimental flags control toss and data balance at the same time.
How do you solve it?
add 2 sub flag, current config only allow data balance.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: