Fix storage index #2828
Closed
Fix storage index #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Sep 9, 2021
src/storage/exec/IndexOutputNode.h
Outdated
| @@ -144,26 +150,22 @@ class IndexOutputNode final : public RelNode<T> { | |||
| ret = vertexRowsFromData(data); | |||
| break; | |||
| } | |||
| default: | |||
| assert(false); | |||
There was a problem hiding this comment.
replace the assert with LOG(FATAL)
| if (v.isStr()) { | ||
| auto iter = std::find_if(fields_.begin(), fields_.end(), [&col](const auto& field) { | ||
| return col == field.get_name(); | ||
| }); |
There was a problem hiding this comment.
CHECK whether the iter is valid: DCHECK(iter != xx.end());
There was a problem hiding this comment.
CHECK whether the iter is valid:
DCHECK(iter != xx.end());
Just share the discussion details, it is not finished
2. fix LookupIndexTest 3. remove buildPlanWithFilter
cangfengzhs
force-pushed
the
fix_storage_index
branch
from
02fd382
to
f881c1f
Compare
|
This bug has been fixed in #3196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can only solve the problem of storing and returning truncated data. It cannot deal with the problem of incorrect data set returned due to index truncation. Later, a detailed design for the processing of truncated indexes will be given for everyone to discuss