Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphd crash when lookup expression contains object parameters #5476

Closed
nebula-bots opened this issue Apr 4, 2023 · 0 comments · Fixed by #5475
Closed

Graphd crash when lookup expression contains object parameters #5476

nebula-bots opened this issue Apr 4, 2023 · 0 comments · Fixed by #5475
Labels
affects/master PR/issue: this bug affects master version. auto-sync process/done Process of bug severity/blocker Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@nebula-bots
Copy link
Contributor

Your Environments (required)
2023.04.02-nightly-ent
15b80ca

How To Reproduce(required)

CREATE TAG player(name string, age int, geo GEOGRAPHY(POINT), update_time timestamp DEFAULT now());
CREATE TAG INDEX IF NOT EXISTS player_geo ON player (geo);

:param p4 => {"s1":"test","s2":"2020-01-01 10:00:00","s3":[1,2,3,4,5],"longitude":[1.0,2.0,3.0],"latitude":[10.1,11.1,12.1]}

LOOKUP ON player WHERE ST_Distance(player.geo, ST_Point($p4.longitude[0], $p4.latitude[1])) < $p4.latitude[4] YIELD id(vertex)

image

core dump

(gdb) bt
#0  0x00007f87d7720387 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:55
#1  0x00007f87d7721a78 in __GI_abort () at abort.c:90
#2  0x000000000268e2aa in google::LogMessage::Fail() ()
#3  0x00000000026913a4 in google::LogMessage::SendToLog() ()
#4  0x000000000268dd79 in google::LogMessage::Flush() ()
#5  0x0000000002691a59 in google::LogMessageFatal::~LogMessageFatal() ()
#6  0x0000000002129ae0 in nebula::Value::getGeography() const ()
#7  0x00000000013d83c4 in nebula::opt::GeoPredicateIndexScanBaseRule::transform(nebula::opt::OptContext*, nebula::opt::MatchedResult const&) const ()
#8  0x00000000013b052a in nebula::opt::OptGroup::explore(nebula::opt::OptRule const*) ()
#9  0x00000000013b0ac1 in nebula::opt::OptGroup::exploreUntilMaxRound(nebula::opt::OptRule const*) ()
#10 0x00000000013b0d0c in nebula::opt::OptGroupNode::explore(nebula::opt::OptRule const*) ()
#11 0x00000000013b03cc in nebula::opt::OptGroup::explore(nebula::opt::OptRule const*) ()
#12 0x00000000013b0ac1 in nebula::opt::OptGroup::exploreUntilMaxRound(nebula::opt::OptRule const*) ()
#13 0x00000000013acd0c in nebula::opt::Optimizer::doExploration(nebula::opt::OptContext*, nebula::opt::OptGroup*) ()
#14 0x00000000013add2f in nebula::opt::Optimizer::findBestPlan(nebula::graph::QueryContext*) ()
#15 0x00000000012b3f49 in nebula::graph::QueryInstance::findBestPlan() ()
#16 0x00000000012b6826 in nebula::graph::QueryInstance::validateAndOptimize() ()
#17 0x00000000012b6e21 in nebula::graph::QueryInstance::execute() ()
#18 0x00000000012b1945 in nebula::graph::QueryEngine::execute(std::unique_ptr<nebula::graph::RequestContext<nebula::ExecutionResponse>, std::default_delete<nebula::graph::RequestContext<nebula::ExecutionResponse> > >) ()
#19 0x000000000127dcfa in nebula::graph::GraphService::future_executeWithParameter(long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, nebula::Value, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, nebula::Value> > > const&)::{lambda(nebula::StatusOr<std::shared_ptr<nebula::graph::ClientSession> >)#1}::operator()(nebula::StatusOr<std::shared_ptr<nebula::graph::ClientSession> >) ()
#20 0x000000000127e241 in _ZN5folly6detail8function14FunctionTraitsIFvRNS_7futures6detail8CoreBaseEONS_8Executor9KeepAliveIS7_EEPNS_17exception_wrapperEEE7callBigIZNS4_4CoreIN6nebula8StatusOrISt10shared_ptrINSH_5graph13ClientSessionEEEEE11setCallbackIZNS4_10FutureBaseISN_E18thenImplementationIZNOS_6FutureISN_E9thenValueIZNSK_12GraphService27future_executeWithParameterElRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKSt13unordered_mapIS12_NSH_5ValueESt4hashIS12_ESt8equal_toIS12_ESaISt4pairIS13_S16_EEEEUlSN_E_EENST_INS4_19valueCallableResultISN_T_E10value_typeEEEOS1J_EUlSA_ONS_3TryISN_EEE_NS4_25tryExecutorCallableResultISN_S1R_vEEEENSt9enable_ifIXntsrNT0_13ReturnsFutureE5valueENS1V_6ReturnEE4typeES1N_S1V_NS4_18InlineContinuationEEUlSA_S1Q_E_EEvS1N_OSJ_INS_14RequestContextEES20_EUlS6_SA_SC_E_EEvS6_SA_SC_RNS1_4DataE ()
#21 0x00000000025c760c in ?? ()
#22 0x0000000002358c47 in virtual thunk to apache::thrift::concurrency::FunctionRunner::run() ()
#23 0x00000000024982c8 in apache::thrift::concurrency::ThreadManager::Impl::Worker::run() ()
#24 0x000000000249a3ce in apache::thrift::concurrency::PthreadThread::threadMain(void*) ()
#25 0x00007f87d7abfea5 in start_thread (arg=0x7f87ccdff700) at pthread_create.c:307
#26 0x00007f87d77e8b0d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Expected behavior
Graph won't crash.

@nebula-bots nebula-bots added affects/master PR/issue: this bug affects master version. auto-sync severity/blocker Severity of bug type/bug Type: something is unexpected labels Apr 4, 2023
@jievince jievince mentioned this issue Apr 4, 2023
11 tasks
@Sophie-Xie Sophie-Xie added this to the v3.5.0 milestone Apr 4, 2023
@github-actions github-actions bot added the process/fixed Process of bug label Apr 4, 2023
@nebula-bots nebula-bots added process/done Process of bug and removed process/fixed Process of bug labels Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/master PR/issue: this bug affects master version. auto-sync process/done Process of bug severity/blocker Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants