Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphd crash #5236

Closed
czpmango opened this issue Jan 11, 2023 · 4 comments · Fixed by #5238
Closed

Graphd crash #5236

czpmango opened this issue Jan 11, 2023 · 4 comments · Fixed by #5238
Assignees
@jievince
Labels
affects/none PR/issue: this bug affects none version. auto-sync process/done Process of bug severity/blocker Severity of bug type/bug Type: something is unexpected
Milestone
v3.4.0

Comments

@czpmango
Copy link
Contributor

Your Environments
nebula 3.3.0

How To Reproduce

go 3 steps from "Tim Duncan" over like,serve where (serve.start_year>2000 or like.likeness>90) and labels($$)[0]=="player" and $$.player.age>40 yield $$ as v

Expected behavior
Get the correct query result.
@czpmango czpmango added the type/bug Type: something is unexpected label Jan 11, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Jan 11, 2023
@HarrisChu HarrisChu added the severity/blocker Severity of bug label Jan 11, 2023
@github-actions github-actions bot removed the severity/none Severity of bug label Jan 11, 2023
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Jan 11, 2023
@xtcyclist
Copy link
Contributor

xtcyclist commented Jan 11, 2023 •
edited
Loading

We have around 2 days to fix this. I'd like to opt for a quick solution that avoids this crash and similar crashes due to the same reason. Leave a root fix for the later version.

@xtcyclist
Copy link
Contributor

A similar crash query provided by @czpmango : match (v:player) where $$.player.age>40 return v

@xtcyclist
Copy link
Contributor

This will not crash but report a wrong result in the Release mode, as it runs into a DLOG(FATAL).

@jievince jievince mentioned this issue Jan 11, 2023
Merged
11 tasks
@github-actions github-actions bot added the process/fixed Process of bug label Jan 11, 2023
@xtcyclist
Copy link
Contributor

xtcyclist commented Jan 11, 2023 •
edited
Loading

This is a very good catch. Exposed a whole type of problems.

@HarrisChu HarrisChu added the process/done Process of bug label Jan 13, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 13, 2023
@wey-gu wey-gu mentioned this issue Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jievince jievince

Labels
affects/none PR/issue: this bug affects none version. auto-sync process/done Process of bug severity/blocker Severity of bug type/bug Type: something is unexpected
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

fix extract props visitor jievince/nebula
5 participants
@HarrisChu @xtcyclist @czpmango @jievince @Sophie-Xie