Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical expression simplification #5067

Closed
jievince opened this issue Dec 16, 2022 · 2 comments · Fixed by #5062
Closed

Logical expression simplification #5067

jievince opened this issue Dec 16, 2022 · 2 comments · Fixed by #5062
Assignees
@jievince
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Milestone
v3.4.0

Comments

@jievince
Copy link
Contributor

Introduction

e.g.
xxx or false should be rewritten into xxx,
xxx or true should be rewritten into true.
Refer to #5062 (comment)

Contents

Related work
@jievince jievince added the type/enhancement Type: make the code neat or more efficient label Dec 16, 2022
@jievince jievince mentioned this issue Dec 16, 2022
Merged
11 tasks
@wey-gu wey-gu mentioned this issue Dec 17, 2022
Closed
@jievince jievince added the type/bug Type: something is unexpected label Dec 19, 2022
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug and removed type/enhancement Type: make the code neat or more efficient labels Dec 19, 2022
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Dec 19, 2022
@jievince jievince changed the title Expression simplification Logical expression simplification Dec 22, 2022
@veezhang
Copy link
Contributor

It's also for and ?
xxx and false to false.
xxx and true to xxx.

@jievince
Copy link
Contributor Author

It's also for and ? xxx and false to false. xxx and true to xxx.

Of course.

@github-actions github-actions bot added the process/fixed Process of bug label Dec 26, 2022
@wey-gu wey-gu mentioned this issue Dec 31, 2022
Closed
@Hester-Gu Hester-Gu added the process/done Process of bug label Jan 13, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jievince jievince

Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

fix wrong vid finder for logic or expr jievince/nebula
4 participants
@veezhang @jievince @Hester-Gu @Sophie-Xie