Bad naming of leftjoin

[jievince]

Introduction

  HashLeftJoin(QueryContext* qctx,
               PlanNode* left,
               PlanNode* right,
               std::vector<Expression*> hashKeys,
               std::vector<Expression*> probeKeys)
      : HashJoin(
            qctx, Kind::kHashLeftJoin, left, right, std::move(hashKeys), std::move(probeKeys)) {}

hashKeys are probeKeys indeed, and probeKeys are hashKeys.
We'd better to cal them leftExprs/rightExprs.

Contents

Related work