Add hosts command does not check if the ip/port is actually in use by nebula process

[Aiee]

Please check the FAQ documentation before raising an issue

Describe the bug (required)

Add hosts command does not check if the ip/port is actually in use by nebula process.
For example if I have the Nebula service listening on these ports

and execute add hosts 127.0.0.1:29562 which adds the ip/port of graph service, the execution is succesful.

Your Environments (required)
Neubla master branch

How To Reproduce(required)

Steps to reproduce the behavior:

1. Open the console
2. run add hosts 127.0.0.1:12334 (no process is using this port)
3. It shows Execution succeeded
   

Expected behavior

An error should be returned.
Additional context

[darionyaphet]

You mean the added address is not sure whether it is the real address?

[darionyaphet]

I can't check this In fact, this is not a bug

[Shylock-Hg]

What' the result of show hosts?

[Aiee]

You mean the added address is not sure whether it is the real address?

Yes. In general, I can come up with 2 situations:

1. IP/PORT is used by a non-storage process, like graphd/metad
2. The address is idle and no process is listening on the port

I'm not sure if this is a bug and I was curious if we can make the execution response more sensible.

[Aiee]

What' the result of show hosts?

show hosts will not print the address added.

[HarrisChu]

1. we allow add a storage not running.
2. if add a wrong port, e.g. graph, and it should reject the invalid heartbeat, so show hosts shows nothing.
3. although it's already add hosts, if there's no available heartbeat, cannot create space.

[Aiee]

Update:
After executing add hosts with a graphd ip/port, the user is able to run create space/tag/edge, but an error occurs when inserting a vertex: [ERROR (-1005)]: Storage Error: part: 12, error: E_RPC_FAILURE(-3).

[darionyaphet]

add hosts + storage host and ip

just regist the storage node

[darionyaphet]

why add hosts with a graphd ip/port it is unnecessary

[Aiee]

why add hosts with a graphd ip/port it is unnecessary

This is a misoperation made by users and it could cause problems that are hard to trace

[critical27]

Case closed, it would be hard to prevent misusage