Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It will crash when executing 500 delete statements at a time. #3518

Closed
ColinChamber opened this issue Dec 21, 2021 · 6 comments
Closed

It will crash when executing 500 delete statements at a time. #3518

ColinChamber opened this issue Dec 21, 2021 · 6 comments
Assignees
Labels
community Source: who proposed the issue type/bug Type: something is unexpected wontfix Solution: this will not be worked on recently

Comments

@ColinChamber
Copy link

ColinChamber commented Dec 21, 2021

It will crash when executing 500 delete statements at a time.

Your Environments (required)

  • OS: Linux fedora 5.14.10-300.fc35.x86_64 #1 SMP Thu Oct 7 20:48:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
  • Compiler: g++ 7.5.0
  • CPU: lscpu
  • Commit id de0302545b08bc73bdb31ade1b566b13e430264c

How To Reproduce(required)
image

DELETE VERTEX "test57022";DELETE VERTEX "test56824";DELETE VERTEX "test57094";DELETE VERTEX "test57020";DELETE VERTEX "test56820";DELETE VERTEX "test56956";DELETE VERTEX "test56884";DELETE VERTEX "test56883";DELETE VERTEX "test57093";DELETE VERTEX "test56819";DELETE VERTEX "test56879";DELETE VERTEX "test56878";DELETE VERTEX "test57016";DELETE VERTEX "test56817";DELETE VERTEX "test56951";DELETE VERTEX "test56876";DELETE VERTEX "test57088";DELETE VERTEX "test56815";DELETE VERTEX "test56814";DELETE VERTEX "test56948";DELETE VERTEX "test56947";DELETE VERTEX "test56946";DELETE VERTEX "test56945";DELETE VERTEX "test57085";DELETE VERTEX "test57083";DELETE VERTEX "test57010";DELETE VERTEX "test56943";DELETE VERTEX "test57008";DELETE VERTEX "test56867";DELETE VERTEX "test56938";DELETE VERTEX "test56864";DELETE VERTEX "test57148";DELETE VERTEX "test57001";DELETE VERTEX "test57146";DELETE VERTEX "test56862";DELETE VERTEX "test57143";DELETE VERTEX "test56997";DELETE VERTEX "test56996";DELETE VERTEX "test56860";DELETE VERTEX "test57068";DELETE VERTEX "test56995";DELETE VERTEX "test56994";DELETE VERTEX "test57140";DELETE VERTEX "test57299";DELETE VERTEX "test56858";DELETE VERTEX "test57210";DELETE VERTEX "test57209";DELETE VERTEX "test57208";DELETE VERTEX "test57138";DELETE VERTEX "test57136";DELETE VERTEX "test57133";DELETE VERTEX "test57064";DELETE VERTEX "test57063";DELETE VERTEX "test57062";DELETE VERTEX "test56993";DELETE VERTEX "test56990";DELETE VERTEX "test56986";DELETE VERTEX "test57204";DELETE VERTEX "test57058";DELETE VERTEX "test57131";DELETE VERTEX "test57203";DELETE VERTEX "test57200";DELETE VERTEX "test57057";DELETE VERTEX "test57130";DELETE VERTEX "test57350";DELETE VERTEX "test57278";DELETE VERTEX "test57055";DELETE VERTEX "test57199";DELETE VERTEX "test57272";DELETE VERTEX "test57271";DELETE VERTEX "test57125";DELETE VERTEX "test57194";DELETE VERTEX "test57050";DELETE VERTEX "test57123";DELETE VERTEX "test57345";DELETE VERTEX "test57191";DELETE VERTEX "test57260";DELETE VERTEX "test57343";DELETE VERTEX "test57047";DELETE VERTEX "test57258";DELETE VERTEX "test57186";DELETE VERTEX "test57256";DELETE VERTEX "test57255";DELETE VERTEX "test57184";DELETE VERTEX "test57412";DELETE VERTEX "test57182";DELETE VERTEX "test57250";DELETE VERTEX "test57180";DELETE VERTEX "test57178";DELETE VERTEX "test57248";DELETE VERTEX "test57331";DELETE VERTEX "test57107";DELETE VERTEX "test57398";DELETE VERTEX "test57104";DELETE VERTEX "test57234";DELETE VERTEX "test57233";DELETE VERTEX "test57327";DELETE VERTEX "test57326";DELETE VERTEX "test57165";DELETE VERTEX "test57164";DELETE VERTEX "test57232";DELETE VERTEX "test57231";DELETE VERTEX "test57230";DELETE VERTEX "test57229";DELETE VERTEX "test57226";DELETE VERTEX "test57224";DELETE VERTEX "test57324";DELETE VERTEX "test57323";DELETE VERTEX "test57321";DELETE VERTEX "test57102";DELETE VERTEX "test57101";DELETE VERTEX "test57162";DELETE VERTEX "test57161";DELETE VERTEX "test57389";DELETE VERTEX "test57306";DELETE VERTEX "test57223";DELETE VERTEX "test57222";DELETE VERTEX "test57219";DELETE VERTEX "test57218";DELETE VERTEX "test57217";DELETE VERTEX "test57215";DELETE VERTEX "test57214";DELETE VERTEX "test57211";DELETE VERTEX "test57155";DELETE VERTEX "test57154";DELETE VERTEX "test57152";DELETE VERTEX "test57524";DELETE VERTEX "test57521";DELETE VERTEX "test57385";DELETE VERTEX "test57381";DELETE VERTEX "test57374";DELETE VERTEX "test57369";DELETE VERTEX "test57368";DELETE VERTEX "test57367";DELETE VERTEX "test57361";DELETE VERTEX "test57463";DELETE VERTEX "test57462";DELETE VERTEX "test57453";DELETE VERTEX "test57451";DELETE VERTEX "test57358";DELETE VERTEX "test57449";DELETE VERTEX "test57448";DELETE VERTEX "test57442";DELETE VERTEX "test57440";DELETE VERTEX "test57437";DELETE VERTEX "test57301";DELETE VERTEX "test57640";DELETE VERTEX "test57639";DELETE VERTEX "test57584";DELETE VERTEX "test57436";DELETE VERTEX "test57509";DELETE VERTEX "test57633";DELETE VERTEX "test57631";DELETE VERTEX "test57579";DELETE VERTEX "test57574";DELETE VERTEX "test57572";DELETE VERTEX "test57570";DELETE VERTEX "test57569";DELETE VERTEX "test57568";DELETE VERTEX "test57502";DELETE VERTEX "test57564";DELETE VERTEX "test57497";DELETE VERTEX "test57495";DELETE VERTEX "test57494";DELETE VERTEX "test57430";DELETE VERTEX "test57628";DELETE VERTEX "test57492";DELETE VERTEX "test57561";DELETE VERTEX "test57560";DELETE VERTEX "test57695";DELETE VERTEX "test57490";DELETE VERTEX "test57557";DELETE VERTEX "test57624";DELETE VERTEX "test57620";DELETE VERTEX "test57693";DELETE VERTEX "test57554";DELETE VERTEX "test57425";DELETE VERTEX "test57423";DELETE VERTEX "test57618";DELETE VERTEX "test57691";DELETE VERTEX "test57688";DELETE VERTEX "test57484";DELETE VERTEX "test57553";DELETE VERTEX "test57422";DELETE VERTEX "test57615";DELETE VERTEX "test57682";DELETE VERTEX "test57416";DELETE VERTEX "test57611";DELETE VERTEX "test57476";DELETE VERTEX "test57475";DELETE VERTEX "test57542";DELETE VERTEX "test57541";DELETE VERTEX "test57415";DELETE VERTEX "test57679";DELETE VERTEX "test57678";DELETE VERTEX "test57609";DELETE VERTEX "test57473";DELETE VERTEX "test57758";DELETE VERTEX "test57536";DELETE VERTEX "test57755";DELETE VERTEX "test57674";DELETE VERTEX "test57673";DELETE VERTEX "test57534";DELETE VERTEX "test57753";DELETE VERTEX "test57672";DELETE VERTEX "test57603";DELETE VERTEX "test57602";DELETE VERTEX "test57467";DELETE VERTEX "test57465";DELETE VERTEX "test57532";DELETE VERTEX "test57531";DELETE VERTEX "test57751";DELETE VERTEX "test57597";DELETE VERTEX "test57595";DELETE VERTEX "test57815";DELETE VERTEX "test57813";DELETE VERTEX "test57812";DELETE VERTEX "test57529";DELETE VERTEX "test57746";DELETE VERTEX "test57659";DELETE VERTEX "test57658";DELETE VERTEX "test57934";DELETE VERTEX "test57933";DELETE VERTEX "test57931";DELETE VERTEX "test57929";DELETE VERTEX "test57810";DELETE VERTEX "test57809";DELETE VERTEX "test57808";DELETE VERTEX "test57807";DELETE VERTEX "test57806";DELETE VERTEX "test57870";DELETE VERTEX "test57866";DELETE VERTEX "test57863";DELETE VERTEX "test57860";DELETE VERTEX "test57859";DELETE VERTEX "test57858";DELETE VERTEX "test57740";DELETE VERTEX "test57737";DELETE VERTEX "test57655";DELETE VERTEX "test57802";DELETE VERTEX "test57735";DELETE VERTEX "test57928";DELETE VERTEX "test57653";DELETE VERTEX "test57652";DELETE VERTEX "test57854";DELETE VERTEX "test57799";DELETE VERTEX "test57728";DELETE VERTEX "test57651";DELETE VERTEX "test57797";DELETE VERTEX "test57649";DELETE VERTEX "test57648";DELETE VERTEX "test57795";DELETE VERTEX "test57794";DELETE VERTEX "test57911";DELETE VERTEX "test58016";DELETE VERTEX "test57910";DELETE VERTEX "test57909";DELETE VERTEX "test57845";DELETE VERTEX "test57720";DELETE VERTEX "test57719";DELETE VERTEX "test57908";DELETE VERTEX "test57907";DELETE VERTEX "test57784";DELETE VERTEX "test57904";DELETE VERTEX "test58004";DELETE VERTEX "test57779";DELETE VERTEX "test57710";DELETE VERTEX "test57709";DELETE VERTEX "test57992";DELETE VERTEX "test57899";DELETE VERTEX "test57837";DELETE VERTEX "test57707";DELETE VERTEX "test57991";DELETE VERTEX "test57990";DELETE VERTEX "test57897";DELETE VERTEX "test57834";DELETE VERTEX "test57895";DELETE VERTEX "test57705";DELETE VERTEX "test57704";DELETE VERTEX "test57989";DELETE VERTEX "test57768";DELETE VERTEX "test57701";DELETE VERTEX "test57832";DELETE VERTEX "test57830";DELETE VERTEX "test57894";DELETE VERTEX "test57889";DELETE VERTEX "test57887";DELETE VERTEX "test57886";DELETE VERTEX "test57765";DELETE VERTEX "test57764";DELETE VERTEX "test57985";DELETE VERTEX "test57984";DELETE VERTEX "test57983";DELETE VERTEX "test57885";DELETE VERTEX "test57884";DELETE VERTEX "test57760";DELETE VERTEX "test57978";DELETE VERTEX "test57821";DELETE VERTEX "test58146";DELETE VERTEX "test57879";DELETE VERTEX "test58071";DELETE VERTEX "test57974";DELETE VERTEX "test57973";DELETE VERTEX "test57972";DELETE VERTEX "test58197";DELETE VERTEX "test58070";DELETE VERTEX "test58067";DELETE VERTEX "test58066";DELETE VERTEX "test58063";DELETE VERTEX "test58194";DELETE VERTEX "test58191";DELETE VERTEX "test58139";DELETE VERTEX "test58246";DELETE VERTEX "test58189";DELETE VERTEX "test58135";DELETE VERTEX "test57951";DELETE VERTEX "test58187";DELETE VERTEX "test58061";DELETE VERTEX "test57947";DELETE VERTEX "test58059";DELETE VERTEX "test58051";DELETE VERTEX "test58047";DELETE VERTEX "test58044";DELETE VERTEX "test58241";DELETE VERTEX "test58240";DELETE VERTEX "test58183";DELETE VERTEX "test58180";DELETE VERTEX "test58175";DELETE VERTEX "test58043";DELETE VERTEX "test58042";DELETE VERTEX "test58041";DELETE VERTEX "test58039";DELETE VERTEX "test58036";DELETE VERTEX "test58033";DELETE VERTEX "test58030";DELETE VERTEX "test58029";DELETE VERTEX "test58026";DELETE VERTEX "test58024";DELETE VERTEX "test58348";DELETE VERTEX "test58234";DELETE VERTEX "test58232";DELETE VERTEX "test58231";DELETE VERTEX "test57942";DELETE VERTEX "test57938";DELETE VERTEX "test57937";DELETE VERTEX "test58128";DELETE VERTEX "test58173";DELETE VERTEX "test58169";DELETE VERTEX "test58168";DELETE VERTEX "test58167";DELETE VERTEX "test58166";DELETE VERTEX "test58163";DELETE VERTEX "test58162";DELETE VERTEX "test58158";DELETE VERTEX "test58228";DELETE VERTEX "test58226";DELETE VERTEX "test58221";DELETE VERTEX "test58219";DELETE VERTEX "test58217";DELETE VERTEX "test58216";DELETE VERTEX "test58346";DELETE VERTEX "test58126";DELETE VERTEX "test58124";DELETE VERTEX "test58122";DELETE VERTEX "test58119";DELETE VERTEX "test58118";DELETE VERTEX "test58116";DELETE VERTEX "test58111";DELETE VERTEX "test58101";DELETE VERTEX "test58099";DELETE VERTEX "test58097";DELETE VERTEX "test58095";DELETE VERTEX "test58091";DELETE VERTEX "test58085";DELETE VERTEX "test58299";DELETE VERTEX "test58296";DELETE VERTEX "test58293";DELETE VERTEX "test58289";DELETE VERTEX "test58287";DELETE VERTEX "test58283";DELETE VERTEX "test58282";DELETE VERTEX "test58280";DELETE VERTEX "test58276";DELETE VERTEX "test58274";DELETE VERTEX "test58273";DELETE VERTEX "test58157";DELETE VERTEX "test58153";DELETE VERTEX "test58152";DELETE VERTEX "test58078";DELETE VERTEX "test58204";DELETE VERTEX "test58150";DELETE VERTEX "test58149";DELETE VERTEX "test58397";DELETE VERTEX "test58456";DELETE VERTEX "test58395";DELETE VERTEX "test58335";DELETE VERTEX "test58453";DELETE VERTEX "test58393";DELETE VERTEX "test58264";DELETE VERTEX "test58333";DELETE VERTEX "test58452";DELETE VERTEX "test58451";DELETE VERTEX "test58198";DELETE VERTEX "test58262";DELETE VERTEX "test58504";DELETE VERTEX "test58389";DELETE VERTEX "test58327";DELETE VERTEX "test58502";DELETE VERTEX "test58501";DELETE VERTEX "test58500";DELETE VERTEX "test58499";DELETE VERTEX "test58442";DELETE VERTEX "test58497";DELETE VERTEX "test58380";DELETE VERTEX "test58495";DELETE VERTEX "test58494";DELETE VERTEX "test58252";DELETE VERTEX "test58251";DELETE VERTEX "test58437";DELETE VERTEX "test58493";DELETE VERTEX "test58376";DELETE VERTEX "test58325";DELETE VERTEX "test58324";DELETE VERTEX "test58323";DELETE VERTEX "test58319";DELETE VERTEX "test58436";DELETE VERTEX "test58434";DELETE VERTEX "test58432";DELETE VERTEX "test58428";DELETE VERTEX "test58426";DELETE VERTEX "test58488";DELETE VERTEX "test58487";DELETE VERTEX "test58486";DELETE VERTEX "test58482";DELETE VERTEX "test58481";DELETE VERTEX "test58317";DELETE VERTEX "test58314";DELETE VERTEX "test58308";DELETE VERTEX "test58557";DELETE VERTEX "test58555";DELETE VERTEX "test58553";DELETE VERTEX "test58552";DELETE VERTEX "test58550";DELETE VERTEX "test58547";DELETE VERTEX "test58371";DELETE VERTEX "test58369";DELETE VERTEX "test58368";DELETE VERTEX "test58424";DELETE VERTEX "test58422";DELETE VERTEX "test58303";DELETE VERTEX "test58479";DELETE VERTEX "test58478";DELETE VERTEX "test58477";DELETE VERTEX "test58365";DELETE VERTEX "test58364";DELETE VERTEX "test58361";DELETE VERTEX "test58421";DELETE VERTEX "test58301";DELETE VERTEX "test58300";DELETE VERTEX "test58476";DELETE VERTEX "test58632";DELETE VERTEX "test58474";DELETE VERTEX "test58473";DELETE VERTEX "test58472";DELETE VERTEX "test58416";DELETE VERTEX "test58536";DELETE VERTEX "test58535";DELETE VERTEX "test58470";DELETE VERTEX "test58355";DELETE VERTEX "test58534";DELETE VERTEX "test58629";DELETE VERTEX "test58468";DELETE VERTEX "test58626";DELETE VERTEX "test58532";DELETE VERTEX "test58467";DELETE VERTEX "test58466";DELETE VERTEX "test58625";DELETE VERTEX "test58530";DELETE VERTEX "test58412";DELETE VERTEX "test58352";DELETE VERTEX "test58623";DELETE VERTEX "test58406";DELETE VERTEX "test58621";DELETE VERTEX "test58528";DELETE VERTEX "test58527";DELETE VERTEX "test58462";DELETE VERTEX "test58461";DELETE VERTEX "test58351";DELETE VERTEX "test58350";DELETE VERTEX "test58704";DELETE VERTEX "test58620";DELETE VERTEX "test58619";DELETE VERTEX "test58459";DELETE VERTEX "test58755";DELETE VERTEX "test58457";DELETE VERTEX "test58610";DELETE VERTEX "test58609";DELETE VERTEX "test58750";DELETE VERTEX "test58814";DELETE VERTEX "test58519";

Expected behavior

Additional context
Maybe because of stack overflow
image
image

@ColinChamber ColinChamber added the type/bug Type: something is unexpected label Dec 21, 2021
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Dec 21, 2021
@jievince
Copy link
Contributor

This is because the current plan of sequential statements is spliced together into one giant plan, which then causes stack overflow when this giant plan enters the optimizer phase. I find there is a variable called kMaxExplorationRound to control the depth of the optimizer, but it's not exposed as a gflag. Do we need to expose it? @yee

@jievince
Copy link
Contributor

This is because the current plan of sequential statements is spliced together into one giant plan, which then causes stack overflow when this giant plan enters the optimizer phase. I find there is a variable called kMaxExplorationRound to control the depth of the optimizer, but it's not exposed as a gflag. Do we need to expose it? @yee

Or will the new execution plan of sequential sentences avoid splicing together the plans?

@Shylock-Hg
Copy link
Contributor

You could delete multiple vertices in on statement.

@ColinChamber
Copy link
Author

ColinChamber commented Dec 22, 2021

Thanks. If it is still 500 delete statements executed together, adjusting kMaxExplorationRound does not solve this problem. Modifying the configuration --enable_optimizer=false, will also enter the optimization phase. I check the source code and find this configuration item will only make the QueryRules become the DefaultRules, which confuses me.@jievince

@jievince
Copy link
Contributor

Thanks. If it is still 500 delete statements executed together, adjusting kMaxExplorationRound does not solve this problem. Modifying the configuration --enable_optimizer=false, will also enter the optimization phase. I check the source code and find this configuration item will only make the QueryRules become the DefaultRules, which confuses me.@jievince

Hi @ColinChamber, you are right. The option enable_optimizer's name is a little confusing.
It does not control whether the optimizer is turned on, it only controls whether it applies QueryRules. So changing this option does not address your problem.
You could try what @Shylock-Hg said:

(root@nebula) [nba]> delete vertex "101", "102";
Execution succeeded (time spent 41570/41991 us)

@ColinChamber
Copy link
Author

Thanks a lot for your advice.

@Sophie-Xie Sophie-Xie assigned yixinglu and unassigned CPWstatic Dec 24, 2021
@Sophie-Xie Sophie-Xie removed this from the v3.0.0 milestone Dec 28, 2021
@CPWstatic CPWstatic added this to the v5.0.0 milestone Apr 8, 2022
@Sophie-Xie Sophie-Xie added the community Source: who proposed the issue label Apr 24, 2022
@Sophie-Xie Sophie-Xie removed this from the v5.0.0 milestone Apr 28, 2022
@Sophie-Xie Sophie-Xie added the wontfix Solution: this will not be worked on recently label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Source: who proposed the issue type/bug Type: something is unexpected wontfix Solution: this will not be worked on recently
Projects
None yet
Development

No branches or pull requests

6 participants