Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #172

Merged
merged 24 commits into from
Nov 25, 2021
Merged

Spelling #172

merged 24 commits into from
Nov 25, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 10, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@bbfd70e#commitcomment-59918145

The action reports that the changes in this PR would make it happy: jsoref@6a78a55

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

jsoref
jsoref commented Nov 10, 2021
View reviewed changes
nebula2/common/ttypes.py Outdated
@@ -117,7 +117,7 @@ class ErrorCode:
E_BALANCED = -2024
E_NO_RUNNING_BALANCE_PLAN = -2025
E_NO_VALID_HOST = -2026
E_CORRUPTTED_BALANCE_PLAN = -2027
E_CORRUPTED_BALANCE_PLAN = -2027
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this appears to relate to a change in vesoft-inc/nebula#3297 which definitely hints that it's an API and thus the typo should probably be retained.

tests/test_data_type.py Show resolved Hide resolved
@Shylock-Hg
Copy link

Why don't add it to github workflow?

@jsoref
Copy link
Contributor Author

jsoref commented Nov 10, 2021

If you're interested in the workflow, I'm happy to. But typically I wait for an invitation.

@Shylock-Hg
Copy link

If you're interested in the workflow, I'm happy to. But typically I wait for an invitation.

I think it's ok, how about you? @Aiee

@Shylock-Hg Shylock-Hg requested a review from Aiee November 10, 2021 08:58
@Shylock-Hg Shylock-Hg added the community Source: who proposed the issue label Nov 10, 2021
@Aiee
Copy link
Contributor

Aiee commented Nov 11, 2021

If you're interested in the workflow, I'm happy to. But typically I wait for an invitation.

Hello @jsoref, this tool indeed makes life easier. Could you please submit a PR to add the action? When you add the action, please ignore /common /fbthrift /graph /meta /storage under the nebula2 directory since the files are auto-generated.

@greyli greyli mentioned this pull request Nov 11, 2021
Merged
jsoref
jsoref commented Nov 11, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
greyli and others added 2 commits November 23, 2021 16:48
@greyli @Aiee
Fix a broken link in the changelog (vesoft-inc#173)
8f3591a
@Aiee @HarrisChu
Update thrift files (vesoft-inc#177)
acfd964 
* Update thirift files

* Fix ci

* enhance

* ignore scan data by next cusor

* Remove code for testing

Co-authored-by: HarrisChu <[email protected]>
@Aiee Aiee merged commit bd72862 into vesoft-inc:master Nov 25, 2021
@jsoref jsoref deleted the spelling branch November 25, 2021 07:47
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

@Aiee Aiee Aiee approved these changes

Assignees
No one assigned
Labels
community Source: who proposed the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoref @Shylock-Hg @Aiee @greyli