Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Session ID for identification #487

Closed
wdroste opened this issue Nov 7, 2022 · 0 comments · Fixed by #490
Closed

Expose Session ID for identification #487

wdroste opened this issue Nov 7, 2022 · 0 comments · Fixed by #490
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wdroste
Copy link
Contributor

wdroste commented Nov 7, 2022

There's a couple of issues w/ SessionManager/SessionWrapper

  • Exposing ping from sessionWrapper would help clients insure the session was still live.
  • Exposing sessionId from sessionWrapper/session would better help track session in other managers.
  • Making objects like session AutoClosable would let users know they need to be either released or closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expose sessionID and ping check Nicole00/nebula-java
2 participants
@wdroste @Sophie-Xie