Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused client options manipulation #203

Open
ctron opened this issue Jun 9, 2021 · 0 comments
Open

Unused client options manipulation #203

ctron opened this issue Jun 9, 2021 · 0 comments
Labels

Comments

@ctron
Copy link
Contributor

ctron commented Jun 9, 2021

In the constructor of the MQTT client, it looks like some changes in the past have changed the originally intended behavior:

public MqttClientImpl(Vertx vertx, MqttClientOptions options) {
// copy given options
NetClientOptions netClientOptions = new NetClientOptions(options);
netClientOptions.setIdleTimeout(DEFAULT_IDLE_TIMEOUT);
this.vertx = (VertxInternal) vertx;
this.options = new MqttClientOptions(options);
this.keepAliveTimeout = ((options.getKeepAliveInterval() * 1000) * 3) / 2;
}

From what I see, the netClientOptions gets copied, manipulated, but then not used at all.

@ctron ctron added the bug label Jun 9, 2021
@pigbayspy pigbayspy mentioned this issue Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant