Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of WebRTC in Node with a new parameter passed to UA? #723

Closed
hieyou1 opened this issue Jul 4, 2021 · 1 comment
Closed

Possibility of WebRTC in Node with a new parameter passed to UA? #723

hieyou1 opened this issue Jul 4, 2021 · 1 comment

Comments

@hieyou1
Copy link

hieyou1 commented Jul 4, 2021

Thanks for taking a look at this. I know that #349, #415, #403, and #310 are all this same thing, but they were also all closed a number of years ago. Now, with great libraries like node-webrtc, which, according to its README, "is a Node.js Native Addon that provides bindings to WebRTC", it is now possible to use WebRTC in Node.

However, it is still not supported by this library. I would really appreciate this feature.

My suggestion for how to implement this is to use a new parameter in JsSIP.UA() called "wrtc" [or something similar], as simple-peer already does. This parameter would be optional, and if left undefined, would default to the "window.*" APIs.

I'm still unsure if solving #427 would solve this problem.

@ibc
Copy link
Member

ibc commented Jul 4, 2021

We won't do that because if we did that we would automatically become responsible of how such a node-webrtc library (that BTW we don't know) behaves, and from my past experience it does not behave well at all.

So instead of that, we are gonna remove WebRTC entirely from JsSIP and make the app responsible of it.

BTW please use the mailing list for questions or suggestions.

@ibc ibc closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants