-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to pass and retrieve hashed SIP password #353
Comments
FWIW, me likey. I'd make the real optional, and set it to the domain by default. Asterisk uses 'asterisk' by default as the realm, so people may want to change it. |
OK, so in practice we would want a new let ua = new JsSIP.UA({
uri: 'sip:[email protected]',
password: '1234fuckmeeasy'
}); and: let ua = new JsSIP.UA({
uri: 'sip:[email protected]',
realm: 'asterisk', // optional, if not set defaults to "atlanta.com"
ha1Password: 'iwudkasjhdk234asd'
}); |
NOTE FOR ME: once first authentication is done, the CONS: rare use case in which the server requires a late authentication with a new |
My two cents, in some weird cases, authentication info could be different than sip info, maybe something like this is could be useful: let ua = new JsSIP.UA({
username: '[email protected]',
auth: {
username: 'alice',
realm: 'foo.com',
ha1Password: 'iwudkasjhdk234asd'
}
}); |
There is already a authorization_user param for that case. Regarding parameters grouping, I like it, but better leave it for a new 0.8.x milestone so we don't break the current API and can add the feature exposed here in the current 0.7.x set of releases. |
Assuming you mean "realm" 👍 |
Kill me. |
Done in master. Also note that, with this new feature and even if no
|
👍 |
Goal:
uri
and clearpassword
as always.ua.getHashedPassword()
that retrievesHA1=MD5(username:realm:password)
(so we need to also set therealm
somehow...uri
andha1Password
instead of plainpassword
.@jmillan any concern about this?
The text was updated successfully, but these errors were encountered: