Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magithub-feature-autoinject error #402

Closed
mgcyung opened this issue Feb 19, 2019 · 1 comment · Fixed by #403
Closed

magithub-feature-autoinject error #402

mgcyung opened this issue Feb 19, 2019 · 1 comment · Fixed by #403
Labels
bug describes a defect in supported/advertised functionality

Comments

@mgcyung
Copy link
Contributor

mgcyung commented Feb 19, 2019

Emacs initialization breaks down on

(after-load 'magit (magithub-feature-autoinject t))

with error

error: feature pull-request-merge failed to install: nil

It seems due to no defination of function "magit-am-popup". Since magit/magit#3728 magit uses Transient instead of Magit-Popup.
@vermiculus
Copy link
Owner

You're right; magithub will need to be ported to transient. I'm unlikely to do this anytime in the next few days ago (what little free time I have, I'm putting into Forge) – do you want to take a crack at a PR? You'll want to adjust magithub-feature-list in magithub-core.el.

@vermiculus vermiculus added the bug describes a defect in supported/advertised functionality label Feb 19, 2019
@mgcyung mgcyung mentioned this issue Feb 19, 2019
Merged
@Miciah Miciah mentioned this issue Feb 19, 2019
Closed
@tarsius tarsius mentioned this issue Feb 21, 2019
Closed
jackson15j added a commit to jackson15j/dot_emacs that referenced this issue May 3, 2019
@jackson15j
Workaround magithub not updating to use transient like magit.
b7db32a 
Bugs:

* magit/magit#3749
* vermiculus/magithub#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug describes a defect in supported/advertised functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use transient instead of magit-popup in magithub-feature-list mgcyung/magithub
2 participants
@vermiculus @mgcyung