Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

fix: verify validation url and email #60

Merged
merged 4 commits into from
May 16, 2019
Merged

Conversation

juanpicado
Copy link
Member

Type: bug

Description:

We verify whether URL and emails are valid.

Resolves
verdaccio/verdaccio#1312

@juanpicado juanpicado requested a review from a team May 16, 2019 06:26
@juanpicado juanpicado requested a review from a team May 16, 2019 06:53
@juanpicado juanpicado self-assigned this May 16, 2019
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #60 into 4.x-master will decrease coverage by 0.13%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff               @@
##           4.x-master      #60      +/-   ##
==============================================
- Coverage       85.15%   85.01%   -0.14%     
==============================================
  Files              55       55              
  Lines             532      534       +2     
  Branches           69       71       +2     
==============================================
+ Hits              453      454       +1     
  Misses             66       66              
- Partials           13       14       +1
Impacted Files Coverage Δ
src/webui/components/Package/index.js 100% <100%> (ø) ⬆️
src/webui/utils/url.js 60% <50%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233ba19...59968fd. Read the comment docs.

@juanpicado juanpicado merged commit 980dac5 into 4.x-master May 16, 2019
@juanpicado juanpicado deleted the feat-url-validator branch May 16, 2019 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants