fix: generate correct registry URL

[DanielRuf]

Type:
bug

The following has been addressed in the PR:

• There is a related issue? Yes
• Unit or Functional tests are included in the PR? Yes

Description:
This PR correctly transforms /in the devmode to a full URL like in production and generates the correct registry URL.

Important: update combineBaseUrl in node_modules/verdaccio/build/lib/utils.js to the result of verdaccio/verdaccio#1647

function combineBaseUrl(protocol, host, prefix) {
  const result = `${protocol}://${host}`;

  const prefixOnlySlash = prefix === '/';
  if (prefix && !prefixOnlySlash) {
    if (prefix.endsWith('/')) {
      prefix = prefix.slice(0, -1);
    }

    if (prefix.startsWith('/')) {
      return `${result}${prefix}`;
    }

    return prefix;
  }

  return result;
}

Resolves verdaccio/verdaccio#1648

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         137      137           
  Lines         956      956           
  Branches      211      197   -14     
=======================================
  Hits          845      845           
- Misses         98       99    +1     
+ Partials       13       12    -1

Impacted Files	Coverage Δ
src/utils/url.ts	20% <100%> (ø)	⬆️
src/components/Icon/styles.ts	88.88% <0%> (ø)	⬆️

[DanielRuf]

Please run yarn build && yarn test:e2e when reviewing / testing.

[juanpicado]

Good one

[juanpicado]

Thanks @DanielRuf now looks much better.

[DanielRuf]

@juanpicado keep in mind that we might need the fix from verdaccio itself too (regarding verdaccio/verdaccio#1647)

[juanpicado]

@DanielRuf do you mean update here the verdaccio dep right?

[DanielRuf]

Exactly. But I see now that this is not released. It's just covering specific use cases.

https://github.com/verdaccio/verdaccio/commits/master

So I guess it is safe to ship the current changes without updating the deps.

[juanpicado]

It will be on Friday. I just need to close one PR and we are done :)