Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

fix: remove whitespace from logo image - closes #374 #400

Merged
merged 4 commits into from
Dec 30, 2019
Merged

fix: remove whitespace from logo image - closes #374 #400

merged 4 commits into from
Dec 30, 2019

Conversation

DanielRuf
Copy link
Contributor

Type:
bugfix

The following has been addressed in the PR:

  • Remove whitespace from image using font-size: 0.

See also https://css-tricks.com/fighting-the-space-between-inline-block-elements/

Description:

Resolves #374

@DanielRuf DanielRuf requested a review from a team December 25, 2019 21:28
juanpicado
juanpicado previously approved these changes Dec 25, 2019
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@juanpicado
Copy link
Member

Again snapshots :( are failing ...

@DanielRuf
Copy link
Contributor Author

@DanielRuf
Copy link
Contributor Author

Failing snapshots, one test would need snapshot updates every year: https://circleci.com/gh/verdaccio/ui/6584?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

We should improve this.

@juanpicado
Copy link
Member

There is something planned https://github.com/verdaccio/ui/issues/199

@juanpicado
Copy link
Member

@DanielRuf could you update snapshots?

@DanielRuf
Copy link
Contributor Author

Which exact command is needed for that and is that currently documented?

@juanpicado
Copy link
Member

At jest you need to add an argument -u. Perhaps worth to add a new script

"test:snapshopts": "npm run test -- -u",

to facilitate this process while the other ticket is being fixed.

@DanielRuf
Copy link
Contributor Author

Might be good to document this in the contributing section of the readme and a CONTRIBUTING file.

I will update the PR later today.

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #400 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #400     +/-   ##
=========================================
- Coverage   87.81%   87.72%   -0.1%     
=========================================
  Files         137      137             
  Lines         952      953      +1     
  Branches      211      198     -13     
=========================================
  Hits          836      836             
- Misses        102      104      +2     
+ Partials       14       13      -1
Impacted Files Coverage Δ
src/components/Header/HeaderLogo.tsx 60% <0%> (-15%) ⬇️
src/components/Icon/styles.ts 88.88% <0%> (ø) ⬆️

@juanpicado juanpicado merged commit 544b999 into verdaccio:master Dec 30, 2019
@DanielRuf DanielRuf deleted the fix/374-header-logo-whitespace branch December 30, 2019 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header icon is displaced in header
2 participants