-
Notifications
You must be signed in to change notification settings - Fork 80
fix: remove whitespace from logo image - closes #374 #400
fix: remove whitespace from logo image - closes #374 #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Again snapshots :( are failing ... |
Some bot token issue: https://github.com/verdaccio/ui/pull/400/checks?check_run_id=363440405 |
Failing snapshots, one test would need snapshot updates every year: https://circleci.com/gh/verdaccio/ui/6584?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link We should improve this. |
There is something planned https://github.com/verdaccio/ui/issues/199 |
@DanielRuf could you update snapshots? |
Which exact command is needed for that and is that currently documented? |
At
to facilitate this process while the other ticket is being fixed. |
Might be good to document this in the I will update the PR later today. |
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=========================================
- Coverage 87.81% 87.72% -0.1%
=========================================
Files 137 137
Lines 952 953 +1
Branches 211 198 -13
=========================================
Hits 836 836
- Misses 102 104 +2
+ Partials 14 13 -1
|
Type:
bugfix
The following has been addressed in the PR:
font-size: 0
.See also https://css-tricks.com/fighting-the-space-between-inline-block-elements/
Description:
Resolves #374