feat: Added Theme and migrate to [email protected] 🚀 #286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 90.31% 89.15% -1.16%
==========================================
Files 140 141 +1
Lines 929 959 +30
Branches 143 177 +34
==========================================
+ Hits 839 855 +16
- Misses 78 93 +15
+ Partials 12 11 -1
|
|
Just for future tracking, referencing the migration issue https://github.com/verdaccio/ui/issues/221 |
|
BTW, The migration to emotion 10 looking great 🤓 |
|
|
||
| import CopyToClipBoard from './CopyToClipBoard'; | ||
| import { CopyIcon } from './styles'; | ||
|
|
||
| jest.mock('../../utils/cli-utils'); | ||
|
|
||
| describe('<CopyToClipBoard /> component', () => { | ||
| let wrapper: ReactWrapper; |
There was a problem hiding this comment.
Any reason why you removed the type here? This now errors again in strict mode, it was already covered :(
There was a problem hiding this comment.
It might be a mistake, I restored them.
There was a problem hiding this comment.
Restored, thanks @tmkn for pointing it out
There was a problem hiding this comment.
Sorry @tmkn I was getting errors due to these types, I removed it for testing purposes and forgot to undo my changes ... good catch!
There was a problem hiding this comment.
@priscilawebdev no worries, I was sure it wasn't intentional, that's what code reviews are for :)
Co-Authored-By: Thomas Klein <[email protected]>
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
There was a problem hiding this comment.
Great @priscilawebdev it is perfect, the UI looks the same, great migration.
juanpicado
changed the title
|
Thanks @anikethsaha and @tmkn for the early reviews 🚀 |
|
thank you team 🤝💪 |
Type: Feat + Refactor + Chore (sorry)
Description:
I have added the emotion theme together with the Material Ui Theme. Since I had some problems due to the old version of emotion, I had to update the all the emotion dependencies and fix all the breaking changes.
Of course, there's a lot to improve, but it's a start 🙃
PS: As soon as they release the fix for this issue emotion-js/emotion#1305, I will remove the
<{theme?: Theme}>and add a file a file with