This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Rest MUI components - Introduced ForwardRef #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/162_introduced_forward_ref_mui_components
…tor/162_introduced_forward_ref_mui_components
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 88.56% 88.98% +0.42%
==========================================
Files 119 139 +20
Lines 883 926 +43
Branches 160 141 -19
==========================================
+ Hits 782 824 +42
- Misses 87 91 +4
+ Partials 14 11 -3
|
priscilawebdev
changed the title
priscilawebdev
changed the title
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
juanpicado
reviewed
Oct 31, 2019
| @@ -28,7 +28,6 @@ const HeaderMenu: React.FC<Props> = ({ onLogout, username, isMenuOpen = false, a | |||
| vertical: 'top', | |||
| horizontal: 'right', | |||
| }} | |||
| id="header--button-account" | |||
There was a problem hiding this comment.
Id might be need it for e2e testing
There was a problem hiding this comment.
good catch :-) but... this id was duplicated .. so 2e2 tests were not passing
juanpicado
approved these changes
Oct 31, 2019
delete-merged-branch
bot
deleted the
refactor/162_introduced_forward_ref_mui_components
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #162
Description:
Wrappedt he rest of MUI components with ForwardRef. That is the reason why this PR got large :D