Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

Dialog Components - Introduced ForwardRef #185

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

priscilawebdev
Copy link
Contributor

Type: Refactor

The following has been addressed in the PR: #162

Description:

Wrapped Material UI Dialog, DialogTitle, DialogActions and DialogContent Components with ForwardRef.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #185 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #185     +/-   ##
=========================================
+ Coverage   88.15%   88.26%   +0.1%     
=========================================
  Files         107      111      +4     
  Lines         912      920      +8     
  Branches      147      163     +16     
=========================================
+ Hits          804      812      +8     
+ Misses         95       94      -1     
- Partials       13       14      +1
Impacted Files Coverage Δ
src/components/RegistryInfoDialog/styles.ts 100% <ø> (ø) ⬆️
src/components/Login/Login.tsx 91.3% <ø> (ø) ⬆️
...mponents/RegistryInfoDialog/RegistryInfoDialog.tsx 100% <ø> (ø) ⬆️
src/muiComponents/DialogActions/DialogActions.tsx 100% <100%> (ø)
src/muiComponents/DialogContent/DialogContent.tsx 100% <100%> (ø)
src/muiComponents/DialogTitle/DialogTitle.tsx 100% <100%> (ø)
src/muiComponents/Dialog/Dialog.tsx 100% <100%> (ø)
src/components/DetailSidebar/DetailSidebar.tsx 85% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3888736...35c17b0. Read the comment docs.

@juanpicado juanpicado merged commit 7548c89 into master Oct 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor/162_introduce_forwardRef_Dialog branch October 12, 2019 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants