Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

ListItem Component - Introduced ForwardRef #183

Merged
merged 7 commits into from
Oct 12, 2019

Conversation

priscilawebdev
Copy link
Contributor

Type: Refactor

The following has been addressed in the PR: #162

Description:

Wrapped Material UI ListItem Component with ForwardRef.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #183 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #183      +/-   ##
=========================================
+ Coverage   88.76%   88.8%   +0.03%     
=========================================
  Files         113     114       +1     
  Lines         917     920       +3     
  Branches      147     147              
=========================================
+ Hits          814     817       +3     
  Misses         90      90              
  Partials       13      13
Impacted Files Coverage Δ
src/components/DetailSidebar/styles.ts 100% <ø> (ø) ⬆️
src/components/Dist/styles.ts 100% <ø> (ø) ⬆️
src/components/Versions/VersionsTagList.tsx 100% <ø> (ø) ⬆️
src/components/Repository/styles.ts 100% <ø> (ø) ⬆️
src/components/Engines/styles.ts 100% <ø> (ø) ⬆️
src/components/Author/styles.ts 100% <ø> (ø) ⬆️
src/components/UpLinks/UpLinks.tsx 88.88% <ø> (ø) ⬆️
src/components/Package/Package.tsx 100% <ø> (ø) ⬆️
src/components/ActionBar/styles.ts 100% <ø> (ø) ⬆️
src/components/Install/InstallListItem.tsx 88.88% <ø> (ø) ⬆️
... and 3 more

juanpicado
juanpicado previously approved these changes Oct 12, 2019
@juanpicado
Copy link
Member

rc/components/ActionBar/ActionBar.tsx:121:12 - error TS2322: Type '{ children: ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)> | null) | (new (props: any) => Component<any, any, any>)>[]; alignItems: "flex-start"; button: boolean; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<StyledStatelessProps<object & Pick<Pick<{ alignItems?: "center" | "flex-start" | undefined; autoFocus?: boolean | undefined; button?: boolean | undefined; ContainerComponent?: "object" | ... 79 more ... | undefined; ... 6 more ...; selected?: boolean | undefin...'.
  Property 'button' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<StyledStatelessProps<object & Pick<Pick<{ alignItems?: "center" | "flex-start" | undefined; autoFocus?: boolean | undefined; button?: boolean | undefined; ContainerComponent?: "object" | ... 79 more ... | undefined; ... 6 more ...; selected?: boolean | undefin...'.

121           <ActionListItem alignItems={'flex-start'} button={true}>
               ~~~~~~~~~~~~~~

There are some lint issues.

juanpicado
juanpicado previously approved these changes Oct 12, 2019
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juanpicado juanpicado merged commit 82d7107 into master Oct 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor/162_introduced_forwardRef_listItem branch October 12, 2019 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants