This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
Typography Component - Introduced ForwardRef #179
Merged
juanpicado
merged 9 commits into
master
from
refactor/162_introduce_forwardRef_typography
Oct 12, 2019
Merged
Typography Component - Introduced ForwardRef #179
juanpicado
merged 9 commits into
master
from
refactor/162_introduce_forwardRef_typography
Oct 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 88.8% 88.87% +0.07%
==========================================
Files 114 116 +2
Lines 920 926 +6
Branches 147 163 +16
==========================================
+ Hits 817 823 +6
+ Misses 90 89 -1
- Partials 13 14 +1
|
tmkn
reviewed
Oct 11, 2019
tmkn
reviewed
Oct 11, 2019
All good, but the snapshots are outdated.
|
juanpicado
approved these changes
Oct 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
delete-merged-branch
bot
deleted the
refactor/162_introduce_forwardRef_typography
branch
October 12, 2019 19:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #162
Description:
Wrapped Material UI Typography Component with ForwardRef. I also divided it into 2 other components: Heading and Text. In the future the Text component will be only of type p, div or span (maybe more?) and we the fontSize, color, etc will be according to verdaccio theme.