Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

Typography Component - Introduced ForwardRef #179

Merged
merged 9 commits into from
Oct 12, 2019

Conversation

priscilawebdev
Copy link
Contributor

@priscilawebdev priscilawebdev commented Oct 11, 2019

Type: Refactor

The following has been addressed in the PR: #162

Description:

Wrapped Material UI Typography Component with ForwardRef. I also divided it into 2 other components: Heading and Text. In the future the Text component will be only of type p, div or span (maybe more?) and we the fontSize, color, etc will be according to verdaccio theme.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #179 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage    88.8%   88.87%   +0.07%     
==========================================
  Files         114      116       +2     
  Lines         920      926       +6     
  Branches      147      163      +16     
==========================================
+ Hits          817      823       +6     
+ Misses         90       89       -1     
- Partials       13       14       +1
Impacted Files Coverage Δ
src/components/Repository/Repository.tsx 100% <ø> (ø) ⬆️
src/components/Help/styles.ts 100% <ø> (ø) ⬆️
src/components/UpLinks/UpLinks.tsx 88.88% <ø> (ø) ⬆️
src/components/Versions/Versions.tsx 91.66% <ø> (ø) ⬆️
src/components/Help/Help.tsx 100% <ø> (ø) ⬆️
src/components/Engines/Engines.tsx 100% <ø> (ø) ⬆️
src/components/Developers/Developers.tsx 100% <ø> (ø) ⬆️
...onents/RegistryInfoContent/RegistryInfoContent.tsx 60% <ø> (ø) ⬆️
src/components/Author/Author.tsx 90.9% <ø> (ø) ⬆️
src/components/Dist/Dist.tsx 88.88% <ø> (ø) ⬆️
... and 17 more

@juanpicado
Copy link
Member

All good, but the snapshots are outdated.

Snapshot Summary
 › 2 snapshots failed from 1 test suite. Inspect your code changes or run `yarn test -u` to update them.

Test Suites: 1 failed, 1 skipped, 34 passed, 35 of 36 total
Tests:       2 failed, 3 skipped, 8 todo, 109 passed, 122 total
Snapshots:   2 failed, 35 passed

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juanpicado juanpicado merged commit a8deeb9 into master Oct 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor/162_introduce_forwardRef_typography branch October 12, 2019 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants