This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Improved Typings #174
Merged
Improved Typings #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmkn
commented
Oct 10, 2019
| @@ -151,6 +151,7 @@ | |||
| "scripts": { | |||
| "type-check": "tsc --noEmit --pretty", | |||
| "type-check:watch": "npm run type-check -- --watch", | |||
| "type-check-strict:watch": "tsc --project ./tsconfig.strict.json --noEmit --pretty --watch", | |||
There was a problem hiding this comment.
added a strict configuration to be able to quickly compare the compile output between this and the standard configuration
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 107 107
Lines 924 924
Branches 144 160 +16
=======================================
Hits 786 786
+ Misses 125 124 -1
- Partials 13 14 +1
Continue to review full report at Codecov.
|
|
|
juanpicado
reviewed
Oct 10, 2019
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "noImplicitAny": true |
juanpicado
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit type information to places that have been implicitly any.
No actual code changes, just improved typings in various places.
Compiling with
noImplicityAnyis now down to double digits 🎉