This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Version Page - Replaces class by func. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
changed the title
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 88.73% 86.84% -1.89%
==========================================
Files 117 116 -1
Lines 932 882 -50
Branches 147 162 +15
==========================================
- Hits 827 766 -61
- Misses 92 100 +8
- Partials 13 16 +3
|
priscilawebdev
changed the title
juanpicado
approved these changes
Oct 12, 2019
juanpicado
suggested changes
Oct 13, 2019
…hub.com:verdaccio/ui into refactor/116_convert_class_to_func_version_page
|
Hmmm, I need to check this e2e test. The page is loading here, I just tested everything ... but maybe something doesn't match the test |
|
@priscilawebdev FYI I added E2E (see workflow details), the page does not load, take your time. |
…hub.com:verdaccio/ui into refactor/116_convert_class_to_func_version_page
|
@juanpicado I have only merged master in this branch and now the e2e tests are passing 🧐 interesting. |
juanpicado
reviewed
Oct 17, 2019
| @@ -0,0 +1,9 @@ | |||
| function getRouterPackageName(packageName: string, scope?: string): string { | |||
There was a problem hiding this comment.
Move this to utilities in a new PR, also router is misleading, it just build a package name based on scope. A getPackageName would fit better here.
juanpicado
reviewed
Oct 17, 2019
| import { PackageMetaInterface } from '../../../types/packageMeta'; | ||
|
|
||
| function isPackageVersionValid(packageMeta: Partial<PackageMetaInterface>, packageVersion?: string): boolean { | ||
| if (!packageVersion || typeof packageVersion === 'undefined') { |
There was a problem hiding this comment.
This is also a utilities. The main reason is is much easier to jest.mock one file rather 10 in the same unit test.
delete-merged-branch
bot
deleted the
refactor/116_convert_class_to_func_version_page
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #116
Unit or Functional tests are included in the PR?
I updated the current tests
Description:
in order to use react hooks, in this PR I updated the Version Page by changing it from a class to a functional component. I have also splitted it's content so that it is clearer.