-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 83.15% 83.27% +0.12%
==========================================
Files 98 97 -1
Lines 944 933 -11
Branches 165 148 -17
==========================================
- Hits 785 777 -8
- Misses 142 144 +2
+ Partials 17 12 -5
Continue to review full report at Codecov.
|
Could you share any analysis that prove the impact of this changes in the bundle size? chunks etc etc ? master vs this PR |
I'll try to give you some numbers tomorrow but here's the short version :
|
@antoinechalifour Well done! 👏 Maybe you could also remove the file "asynComponent", because it is not being used anymore |
I think it's already been removed ! I'll check tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoinechalifour thanks for bring the router and code splitting to the next level 👏
Type: Refactor
The following has been addressed in the PR: Use
React.Lazy
for loading components