Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

fix: tarball download not working on Firefox and Edge #144

Merged

Conversation

sumanbh
Copy link
Member

@sumanbh sumanbh commented Oct 1, 2019

Type: bug

The following has been addressed in the PR:

  • Tarball downloads are now working correctly on latest Firefox, Edge, Chrome, and Safari.

Description:

Resolves #119

@codecov-io
Copy link

Codecov Report

Merging #144 into master will decrease coverage by 0.72%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #144      +/-   ##
=========================================
- Coverage   84.12%   83.4%   -0.73%     
=========================================
  Files          92      92              
  Lines         926     934       +8     
  Branches      166     167       +1     
=========================================
  Hits          779     779              
- Misses        128     136       +8     
  Partials       19      19
Impacted Files Coverage Δ
src/utils/url.ts 20% <0%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584f4c1...d14388a. Read the comment docs.

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant 🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download tarball on Firefox and Edge doesn't work properly
3 participants