-
Notifications
You must be signed in to change notification settings - Fork 80
Version Component - Replaced classes by func. comp #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 84.12% 84.14% +0.01%
==========================================
Files 92 94 +2
Lines 926 927 +1
Branches 166 151 -15
==========================================
+ Hits 779 780 +1
- Misses 128 132 +4
+ Partials 19 15 -4
Continue to review full report at Codecov.
|
@@ -14,6 +14,7 @@ export const Spacer = styled('div')({ | |||
borderBottom: '1px dotted rgba(0, 0, 0, 0.2)', | |||
whiteSpace: 'nowrap', | |||
height: '0.5em', | |||
margin: '0 16px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give more context about the margin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there was no space between the Tabs component and the content, so I added 16px margin. Maybe in the future we may have some common spaces, making the application more homogeneous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 really good, short and even increases the coverage 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 👍 good job pris
Type: Refactor
The following has been addressed in the PR: https://github.com/verdaccio/ui/issues/116
Unit or Functional tests are included in the PR?
It was not necessary to update the existing ones
Description:
in order to use react hooks, in this PR I updated the Version component by changing it from a class to a functional component. I have also splitted it's content so that it is clearer.