Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

fix: remove ToReplaceByVerdaccio #108 #122

Merged
merged 2 commits into from
Aug 25, 2019
Merged

fix: remove ToReplaceByVerdaccio #108 #122

merged 2 commits into from
Aug 25, 2019

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Aug 25, 2019

Type: bug

Description:

it populates CSS url() props with ToReplaceByVerdaccio which cannot be replaced anyway, this PR remove that string.

https://github.com/verdaccio/ui/issues/108

Resolves #108

it populates CSS url() props with ToReplaceByVerdaccio which cannot be replaced anyway, this PR remove that string.

https://github.com/verdaccio/ui/issues/108
@@ -1,2 +1 @@
save-prefix ""
registry "http://registry.npmjs.org/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this

@juanpicado juanpicado added this to the candidate for next release milestone Aug 25, 2019
@codecov-io
Copy link

codecov-io commented Aug 25, 2019

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #122   +/-   ##
======================================
  Coverage    84.9%   84.9%           
======================================
  Files          92      92           
  Lines         888     888           
  Branches      142     157   +15     
======================================
  Hits          754     754           
+ Misses        119     116    -3     
- Partials       15      18    +3
Impacted Files Coverage Δ
src/components/Header/Header.tsx 89.47% <0%> (ø) ⬆️
src/components/Install/Install.tsx 83.33% <0%> (ø) ⬆️
...mponents/RegistryInfoDialog/RegistryInfoDialog.tsx 66.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac58730...c377d65. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Pathing issue in Master
2 participants