Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wrap-around selection for TUI. #9409

Merged
merged 6 commits into from
Nov 8, 2024
Merged

feat: Wrap-around selection for TUI. #9409

merged 6 commits into from
Nov 8, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 7, 2024

Description

We previously didn't let you "wrap" your selection to the selected task if you were at the top or bottom of the task list. Now we do!

Testing Instructions

Run some tasks with the TUI and:

  • Press ↑ when you have the top item in the list selected.
  • Press ↓ when you have the bottom item in the list selected.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 3:02am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 3:02am

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

crates/turborepo-ui/src/tui/app.rs Outdated Show resolved Hide resolved
crates/turborepo-ui/src/tui/app.rs Outdated Show resolved Hide resolved
@anthonyshew anthonyshew merged commit bb9871d into main Nov 8, 2024
40 checks passed
@anthonyshew anthonyshew deleted the shew-07b75 branch November 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants