refactor(tui): Use color instead of bars to distinguish sections of task list. #9365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
anthonyshew
changed the title
Not to my knowledge. I think we would need to query the terminal for the default fg/bg colors (I do not know how to do this in a terminal agnostic way), some heuristic for deciding if bg was dark/light, and just have two sets of colors. |
chris-olszewski
approved these changes
Nov 1, 2024
Co-authored-by: Chris Olszewski <[email protected]>
Co-authored-by: Chris Olszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen real estate is valuable.
We were using horizontal bars to distinguish the header and footer from the task list itself. Instead, let's use color, and get rid of the bars.
Testing Instructions
👀
I checked light mode for color contrast, as well, and did the best I could. I don't know if there's a way to tell Ratatui to use different foreground colors for light vs. dark backgrounds? I at least couldn't find any documentation on it or example in our codebase.
Before:
After:
