feat: support task id entrypoints #9344
Merged
+161
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tknickman
approved these changes
Oct 29, 2024
NicholasLYang
approved these changes
Oct 29, 2024
NicholasLYang
approved these changes
Oct 29, 2024
anthonyshew
added a commit
that referenced
this pull request
Nov 14, 2024
# DO MOT MERGE CONDITION 2.3 release ### Description Documenting #9344. ### Testing Instructions 👀
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if you run
turbo cli#buildyou will get the following failure*:*It works if you had
"tasks": {"cli#build": {...}}in your root levelturbo.jsonAfter this PR, passing a fully qualified task id to run will now work, regardless of how the task definition is defined:
turbo.jsonasbuildturbo.jsonascli#buildcliworkspace'sturbo.jsonasbuildThe usage of
#is safe here as you already have been unable to use#in a unqualified task name.#in a task name in a workspace levelturbo.jsonyou will get an error about using package task syntax in a workspace file.turbo.jsonof the formfoo#barit will be read as thebartask in packagefoofoo#bar#bazas a task name in rootturbo.jsonit will work currently withfoo#bar#bazand after this PR it will continue to workTesting Instructions
Added unit tests!
Manual verification by running
turbo cli#build.