Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade TypeScript one minor to 5.4.5 from 5.3.3 #9322

Merged
merged 8 commits into from
Oct 24, 2024
Merged

upgrade TypeScript one minor to 5.4.5 from 5.3.3 #9322

merged 8 commits into from
Oct 24, 2024

Conversation

dimitropoulos
Copy link
Contributor

Description

in working on #9155 I've noticed that we also need to upgrade TypeScript, so I'm doing that here, perhaps not all the way to latest.

Testing Instructions

Everything should work normally - this shouldn't have any behavioral changes.

@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples area: site labels Oct 23, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 6:29pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 6:29pm

@socket-security Socket Security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@dimitropoulos dimitropoulos marked this pull request as ready for review October 23, 2024 18:43
@dimitropoulos dimitropoulos changed the title upgrade to a supported version of TypeScript upgrade TypeScript one minor to 5.4.5 from 5.3.3 Oct 23, 2024
chris-olszewski
chris-olszewski requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR is good, but just marking not to merge this until we get an examples test run with these changes.

The examples test was a >>> FULL TURBO. Even though the examples most definitely changed.

It looks like our example tests aren't actually depending on the examples. I think we're missing a ^topo somewhere

@anthonyshew
Copy link
Contributor

Huh, that's really weird. You could also choose to bump it everywhere except in the examples? I would hope that would work...

chris-olszewski
chris-olszewski approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked task inputs and it was a false alarm.

LGTM, thanks for bumping these.

@dimitropoulos dimitropoulos merged commit be0f18a into main Oct 24, 2024
44 checks passed
@dimitropoulos dimitropoulos deleted the dimitri/upgrade-typescript branch October 24, 2024 14:27
@dimitropoulos dimitropoulos mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@anthonyshew anthonyshew Awaiting requested review from anthonyshew anthonyshew is a code owner

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples area: site pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-gen pkg: turbo-ignore packages/turbo-ignore pkg: turbo-repository pkg: turbo-telemetry pkg: turbo-workspaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimitropoulos @anthonyshew @chris-olszewski