feat(ecma-analyzer): support super() call in class ctor #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for 5f6f054
Click to view full benchmark
|
Windows Benchmark for 5f6f054
Click to view full benchmark
|
MacOS Benchmark for 5f6f054
Click to view full benchmark
|
kdy1
approved these changes
Jun 27, 2023
kwonoj
force-pushed
the
feat-support-super-call
branch
from
9ccc415 to
ccdfaeb
Compare
jridgewell
approved these changes
Jun 27, 2023
Linux Benchmark for f0bc234
Click to view full benchmark
|
Linux Benchmark for da4b1f3Click to view benchmark
|
MacOS Benchmark for da4b1f3
Click to view full benchmark
|
1 task
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…repo#5392) ### Description Attempt to close WEB-1089. PR tries to support import resolustion inside of `super` call, if given args are referencing esm imports. Since super() is sort of expr_call, I originally tried to reuse JsValue::Call as-is but not successfully. Still that might be a simple mistake and new addition to JsValue::Super may not be required.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…repo#5392) ### Description Attempt to close WEB-1089. PR tries to support import resolustion inside of `super` call, if given args are referencing esm imports. Since super() is sort of expr_call, I originally tried to reuse JsValue::Call as-is but not successfully. Still that might be a simple mistake and new addition to JsValue::Super may not be required.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…repo#5392) ### Description Attempt to close WEB-1089. PR tries to support import resolustion inside of `super` call, if given args are referencing esm imports. Since super() is sort of expr_call, I originally tried to reuse JsValue::Call as-is but not successfully. Still that might be a simple mistake and new addition to JsValue::Super may not be required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to close WEB-1089.
PR tries to support import resolustion inside of
supercall, if given args are referencing esm imports.Since super() is sort of expr_call, I originally tried to reuse JsValue::Call as-is but not successfully. Still that might be a simple mistake and new addition to JsValue::Super may not be required.