Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for next.js changes to env vars #5361

Merged
merged 1 commit into from
Jun 26, 2023
Merged

update for next.js changes to env vars #5361

merged 1 commit into from
Jun 26, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 22, 2023

Description

update for vercel/next.js#51353

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:34pm
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:34pm
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:34pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:34pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 7:34pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 7:34pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 22, 2023 7:34pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 7:34pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 7:34pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 22, 2023 7:34pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 7:34pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

🟢 CI successful 🟢

Thanks

@sokra sokra requested a review from kwonoj June 22, 2023 15:38
Copy link
Contributor

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in my changes so you can rebase & test - preapproving as change itself looks correct.

You can manually trigger workflow and check
image

Note actions are running with continue-on-error to not fail with test failures, so have to manually check CI logs to confirm this behavior changes.

@sokra
Copy link
Member Author

sokra commented Jun 22, 2023

@sokra sokra merged commit f448cb5 into main Jun 26, 2023
@sokra sokra deleted the sokra/force-turbopack branch June 26, 2023 10:25
sokra added a commit to vercel/next.js that referenced this pull request Jun 29, 2023
Reverts #51940

### What?

Update SWC crates and turbopack

### Turbopack Updates

* vercel/turborepo#5366 <!-- Justin Ridgewell - Fix
bug with `imports` field from a nested directory -->
* vercel/turborepo#5361 <!-- Tobias Koppers - update
for next.js changes to env vars -->
* vercel/turborepo#5311 <!-- OJ Kwon -
test(filetrace): skip failing tests -->
* vercel/turborepo#5402 <!-- Leah - reduce indent in
`analyze_ecmascript_module` by splitting the function up -->
* vercel/turborepo#5412 <!-- Leah - Update
`swc_core` to `v0.78.24` -->

Closes WEB-1174

Turbopack counterpart: vercel/turborepo#5412

---------

Co-authored-by: Tobias Koppers <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants