Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: recommended publishing script only works if dev also enables changeset commits #9324

Closed
olets opened this issue Oct 24, 2024 · 0 comments · Fixed by #9325
Closed

Docs: recommended publishing script only works if dev also enables changeset commits #9324

olets opened this issue Oct 24, 2024 · 0 comments · Fixed by #9325
Labels
area: docs Improvements or additions to documentation

Comments

@olets
Copy link
Contributor

olets commented Oct 24, 2024

What is the improvement or update you wish to see?

The recommended package publishing workflow has a bad result. With the default changeset configuration, the script will bump package's versions, not commit or push the changes, and publish to npm at the uncommitted version. The result is the registry version bumps but the newly cut version has the unchanged package.json>"version" value.

Is there any context that might help us understand?

This field probably shouldn't be required.

Does the docs page already exist? Please link to it.

https://turbo.build/repo/docs/guides/publishing-libraries#using-changesets-with-turborepo

olets added a commit to olets/vercel--turborepo that referenced this issue Oct 24, 2024
@anthonyshew anthonyshew added the area: docs Improvements or additions to documentation label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants