You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
When I use npx turbo-ignore -- fallback=HEAD~10 or npx turbo-ignore -- fallback=[SHA], I find it always prompts me ⏭ Ignoring the change( Unless I make relevant modifications in HEAD ^, turbo ignore doesn't seem to care about my specified commit, it only compares with HEAD ^
for example I modified packages/A and submitted a commit. Assuming the SHA of this commit is 001, when I run npx turbo ignore packages/A -- fallback=001 its judgment is normal and it will prompt me to Proceeding with deployment; Then I modified packages/B, packages/c, or unrelated files and submitted multiple commits. At this point, I ran npx turbo ignore packages/A again -- fallback=001, and it prompted me ⏭ Ignoring the change
Expected Behavior
When there are related modifications to the commit I specify, it should prompt me to ✓ Processing with deployment
To Reproduce
Modify a file in package/A and submit commit [001]
Execute Command npx turbo ignore packages/A -- fallback=001 (It's normal at this point, prompt me ✓ Processing with deployment
Modify a file in package/B and submit commit [002]
Modify a file in package/C and submit commit [003]
Execute Command npx turbo ignore packages/A -- fallback=001 (It's abnormal at this point, prompt me ⏭ Ignoring the change
Reproduction Repo
No response
The text was updated successfully, but these errors were encountered:
Hey @qigemingzizenmezhemekunnan thanks for the report. Unless you're deploying on Vercel, turbo-ignore will always compare with HEAD^. The fallback arg is only used when the following conditions are both true:
Deploying on Vercel
The previously deployed commit SHA can't be found
That being said, this is something we can support, and we do have another issue for it here: #5080
I'm going to close this one to consolidate, thanks!
What version of Turborepo are you using?
1.10.0
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
When I use npx turbo-ignore -- fallback=HEAD~10 or npx turbo-ignore -- fallback=[SHA], I find it always prompts me ⏭ Ignoring the change( Unless I make relevant modifications in HEAD ^, turbo ignore doesn't seem to care about my specified commit, it only compares with HEAD ^
for example I modified packages/A and submitted a commit. Assuming the SHA of this commit is 001, when I run
npx turbo ignore packages/A -- fallback=001
its judgment is normal and it will prompt me toProceeding with deployment
; Then I modified packages/B, packages/c, or unrelated files and submitted multiple commits. At this point, I ran npx turbo ignore packages/A again -- fallback=001, and it prompted me⏭ Ignoring the change
Expected Behavior
When there are related modifications to the commit I specify, it should prompt me to
✓ Processing with deployment
To Reproduce
npx turbo ignore packages/A -- fallback=001
(It's normal at this point, prompt me✓ Processing with deployment
npx turbo ignore packages/A -- fallback=001
(It's abnormal at this point, prompt me⏭ Ignoring the change
Reproduction Repo
No response
The text was updated successfully, but these errors were encountered: