-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump typescript and apply nodenext module resolution #2084
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5923af3:
|
I just realize that we could not remove the package.json name beacause turbo need them to construct the dep graphs. 🥲 Or we can just only use pnpm mororepo features "scripts": {
"csb:install": "pnpm i -g pnpm@7",
"csb:build": "pnpm install && pnpm build",
"clean": "pnpm -r run clean",
"watch": "pnpm -r run watch",
"build": "pnpm -r run build",
"types:check": "pnpm -r run types:check",
"watch:core": "pnpm --filter=\"./core\" run watch",
"watch:infinite": "pnpm --filter=\"./inifinite\" run watch",
"watch:immutable": "pnpm --filter=\"./immutable\" run watch",
"watch:mutation": "pnpm --filter=\"./mutation\" run watch",
"watch:internal": "pnpm --filter=\"./_internal\" run watch",
"build:core": "pnpm --filter=\"./core\" build",
"build:infinite": "pnpm --filter=\"./infinite\" build",
"build:immutable": "pnpm --filter=\"./immutable\" build",
"build:mutation": "pnpm --filter=\"./mutation\" build",
"build:internal": "pnpm --filter=\"./_internal\" build",
"prepublishOnly": "pnpm clean && pnpm build",
"publish-beta": "pnpm publish --tag beta",
"format": "prettier --write ./**/*.{ts,tsx}",
"lint": "eslint . --ext .ts,.tsx --cache",
"lint:fix": "pnpm lint --fix",
"coverage": "jest --coverage",
"test-typing": "tsc --noEmit -p test/type/tsconfig.json && tsc --noEmit -p test/tsconfig.json",
"test": "jest"
} |
Interesting, how come it builds successfully on main…thanks for checking, will rethink of the approach |
Bump typescript to 4.7 and use
nodenext
for module resolutionx-ref: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#esm-nodejs