added logic to keep query and hash upon redirect with preserveQuery flag #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warren-bank
added a commit
to warren-bank/node-serve
that referenced
this pull request
Dec 22, 2021
when the requested URL is redirected, as the result of:
config.redirects
preserve the querystring and hash, conditional to:
config.redirects[index].preserveQuery
config.redirects[index].preserveHash
when the requested URL is redirected, as the result of either:
config.cleanUrls
config.trailingSlash
preserve the querystring and hash, without condition
based on:
* upstream PR 154
vercel/serve-handler#154
* upstream PR 144
vercel/serve-handler#144
warren-bank
added a commit
to warren-bank/node-serve
that referenced
this pull request
Dec 22, 2021
when the requested URL is redirected, as the result of:
config.redirects
preserve the querystring and hash, conditional to:
config.redirects[index].preserveQuery
config.redirects[index].preserveHash
when the requested URL is redirected, as the result of either:
config.cleanUrls
config.trailingSlash
preserve the querystring and hash, without condition
based on:
* upstream PR 154
vercel/serve-handler#154
* upstream PR 144
vercel/serve-handler#144
warren-bank
added a commit
to warren-bank/node-serve
that referenced
this pull request
Dec 22, 2021
when the requested URL is redirected, as the result of:
config.redirects
preserve the querystring and hash, conditional to:
config.redirects[index].preserveQuery
config.redirects[index].preserveHash
when the requested URL is redirected, as the result of either:
config.cleanUrls
config.trailingSlash
preserve the querystring and hash, without condition
based on:
* upstream PR 154
vercel/serve-handler#154
* upstream PR 144
vercel/serve-handler#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #153 I have added the ability to preserve query and hash strings upon redirect.
This is useful for SEO purposes.