From 1200f78cbb0c2227f7d43a6e1255855179fdbe90 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Mon, 21 Nov 2022 13:26:46 -0800 Subject: [PATCH 1/4] Update run-tests config --- run-tests.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/run-tests.js b/run-tests.js index f82c2eed60665..1f3ce86b20cb4 100644 --- a/run-tests.js +++ b/run-tests.js @@ -243,7 +243,8 @@ async function main() { const start = new Date().getTime() let outputChunks = [] - const shouldRecordTestWithReplay = process.env.RECORD_REPLAY && isRetry + const shouldRecordTestWithReplay = + false && process.env.RECORD_REPLAY && isRetry const child = spawn( jestPath, From 3355ac1ff1199925ccdd1b5bce0a0d303b1a596f Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Mon, 21 Nov 2022 14:01:16 -0800 Subject: [PATCH 2/4] update config --- .github/workflows/build_test_deploy.yml | 102 ++++++++++++------------ run-tests.js | 3 +- 2 files changed, 52 insertions(+), 53 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index 5385a03bcada0..dbcf78dd90584 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -297,25 +297,25 @@ jobs: timeout-minutes: 10 if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: npx @replayio/playwright install chromium - if: ${{needs.build.outputs.docsChange == 'nope'}} + # - run: npx @replayio/playwright install chromium + # if: ${{needs.build.outputs.docsChange == 'nope'}} - run: node run-tests.js --type development --timings -g ${{ matrix.group }}/2 name: Run test/development if: ${{needs.build.outputs.docsChange == 'nope'}} env: - RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDev / Group ${{ matrix.group }} - RECORD_ALL_CONTENT: 1 - RECORD_REPLAY: 1 - RECORD_REPLAY_TEST_METRICS: 1 - RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - - - uses: replayio/action-upload@v0.4.5 - if: always() - with: - api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti - public: true - filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDev / Group ${{ matrix.group }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + + # - uses: replayio/action-upload@v0.4.5 + # if: always() + # with: + # api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti + # public: true + # filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} - name: Upload test trace if: always() @@ -375,26 +375,26 @@ jobs: timeout-minutes: 10 if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: npx @replayio/playwright install chromium - if: ${{needs.build.outputs.docsChange == 'nope'}} + # - run: npx @replayio/playwright install chromium + # if: ${{needs.build.outputs.docsChange == 'nope'}} - run: node run-tests.js --type e2e --timings -g ${{ matrix.group }}/3 name: Run test/e2e (dev) if: ${{needs.build.outputs.docsChange == 'nope'}} env: - RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDevE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} - RECORD_ALL_CONTENT: 1 - RECORD_REPLAY: 1 - NEXT_TEST_MODE: dev - RECORD_REPLAY_TEST_METRICS: 1 - RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - - - uses: replayio/action-upload@v0.4.5 - if: always() - with: - api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti - public: true - filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDevE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # NEXT_TEST_MODE: dev + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + + # - uses: replayio/action-upload@v0.4.5 + # if: always() + # with: + # api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti + # public: true + # filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} - name: Upload test trace if: always() @@ -453,18 +453,18 @@ jobs: timeout-minutes: 10 if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: npx @replayio/playwright install chromium - if: ${{needs.build.outputs.docsChange == 'nope'}} + # - run: npx @replayio/playwright install chromium + # if: ${{needs.build.outputs.docsChange == 'nope'}} - run: node run-tests.js --type production --timings -g ${{ matrix.group }}/2 name: Run test/production if: ${{needs.build.outputs.docsChange == 'nope'}} env: - RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProd / Group ${{ matrix.group }} / Node ${{ matrix.node }} - RECORD_ALL_CONTENT: 1 - RECORD_REPLAY: 1 - RECORD_REPLAY_TEST_METRICS: 1 - RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProd / Group ${{ matrix.group }} / Node ${{ matrix.node }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - uses: replayio/action-upload@v0.4.5 if: always() @@ -521,19 +521,19 @@ jobs: timeout-minutes: 10 if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: npx @replayio/playwright install chromium - if: ${{needs.build.outputs.docsChange == 'nope'}} + # - run: npx @replayio/playwright install chromium + # if: ${{needs.build.outputs.docsChange == 'nope'}} - run: node run-tests.js --type e2e --timings -g ${{ matrix.group }}/3 name: Run test/e2e (production) if: ${{needs.build.outputs.docsChange == 'nope'}} env: - RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProdE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} - RECORD_ALL_CONTENT: 1 - RECORD_REPLAY: 1 - NEXT_TEST_MODE: start - RECORD_REPLAY_TEST_METRICS: 1 - RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProdE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # NEXT_TEST_MODE: start + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - uses: replayio/action-upload@v0.4.5 if: always() @@ -611,17 +611,17 @@ jobs: timeout-minutes: 10 if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: npx @replayio/playwright install chromium - if: ${{needs.build.outputs.docsChange == 'nope'}} + # - run: npx @replayio/playwright install chromium + # if: ${{needs.build.outputs.docsChange == 'nope'}} - run: xvfb-run node run-tests.js --timings -g ${{ matrix.group }}/20 if: ${{needs.build.outputs.docsChange == 'nope'}} env: - RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testIntegration / Group ${{ matrix.group }} - RECORD_ALL_CONTENT: 1 - RECORD_REPLAY: 1 - RECORD_REPLAY_TEST_METRICS: 1 - RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testIntegration / Group ${{ matrix.group }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - uses: replayio/action-upload@v0.4.5 if: always() diff --git a/run-tests.js b/run-tests.js index 1f3ce86b20cb4..f82c2eed60665 100644 --- a/run-tests.js +++ b/run-tests.js @@ -243,8 +243,7 @@ async function main() { const start = new Date().getTime() let outputChunks = [] - const shouldRecordTestWithReplay = - false && process.env.RECORD_REPLAY && isRetry + const shouldRecordTestWithReplay = process.env.RECORD_REPLAY && isRetry const child = spawn( jestPath, From d68f275f1ae88ebc3273644dc8d1c8c40548ac92 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Mon, 21 Nov 2022 14:07:54 -0800 Subject: [PATCH 3/4] update --- .github/workflows/build_test_deploy.yml | 107 +++++++++++------------- 1 file changed, 51 insertions(+), 56 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index dbcf78dd90584..0477dd939bb76 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -299,16 +299,15 @@ jobs: # - run: npx @replayio/playwright install chromium # if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: node run-tests.js --type development --timings -g ${{ matrix.group }}/2 name: Run test/development if: ${{needs.build.outputs.docsChange == 'nope'}} - env: - # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDev / Group ${{ matrix.group }} - # RECORD_ALL_CONTENT: 1 - # RECORD_REPLAY: 1 - # RECORD_REPLAY_TEST_METRICS: 1 - # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # env: + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDev / Group ${{ matrix.group }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} # - uses: replayio/action-upload@v0.4.5 # if: always() @@ -377,17 +376,16 @@ jobs: # - run: npx @replayio/playwright install chromium # if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: node run-tests.js --type e2e --timings -g ${{ matrix.group }}/3 name: Run test/e2e (dev) if: ${{needs.build.outputs.docsChange == 'nope'}} - env: - # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDevE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} - # RECORD_ALL_CONTENT: 1 - # RECORD_REPLAY: 1 - # NEXT_TEST_MODE: dev - # RECORD_REPLAY_TEST_METRICS: 1 - # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # env: + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDevE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # NEXT_TEST_MODE: dev + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} # - uses: replayio/action-upload@v0.4.5 # if: always() @@ -455,23 +453,22 @@ jobs: # - run: npx @replayio/playwright install chromium # if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: node run-tests.js --type production --timings -g ${{ matrix.group }}/2 name: Run test/production if: ${{needs.build.outputs.docsChange == 'nope'}} - env: - # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProd / Group ${{ matrix.group }} / Node ${{ matrix.node }} - # RECORD_ALL_CONTENT: 1 - # RECORD_REPLAY: 1 - # RECORD_REPLAY_TEST_METRICS: 1 - # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # env: + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProd / Group ${{ matrix.group }} / Node ${{ matrix.node }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - - uses: replayio/action-upload@v0.4.5 - if: always() - with: - api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti - public: true - filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} + # - uses: replayio/action-upload@v0.4.5 + # if: always() + # with: + # api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti + # public: true + # filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} testProdE2E: name: Test Production (E2E) @@ -523,24 +520,23 @@ jobs: # - run: npx @replayio/playwright install chromium # if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: node run-tests.js --type e2e --timings -g ${{ matrix.group }}/3 name: Run test/e2e (production) if: ${{needs.build.outputs.docsChange == 'nope'}} - env: - # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProdE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} - # RECORD_ALL_CONTENT: 1 - # RECORD_REPLAY: 1 - # NEXT_TEST_MODE: start - # RECORD_REPLAY_TEST_METRICS: 1 - # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - - - uses: replayio/action-upload@v0.4.5 - if: always() - with: - api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti - public: true - filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} + # env: + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProdE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # NEXT_TEST_MODE: start + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + + # - uses: replayio/action-upload@v0.4.5 + # if: always() + # with: + # api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti + # public: true + # filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} testIntegration: name: Test Integration @@ -613,22 +609,21 @@ jobs: # - run: npx @replayio/playwright install chromium # if: ${{needs.build.outputs.docsChange == 'nope'}} - - run: xvfb-run node run-tests.js --timings -g ${{ matrix.group }}/20 if: ${{needs.build.outputs.docsChange == 'nope'}} - env: - # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testIntegration / Group ${{ matrix.group }} - # RECORD_ALL_CONTENT: 1 - # RECORD_REPLAY: 1 - # RECORD_REPLAY_TEST_METRICS: 1 - # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} + # env: + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testIntegration / Group ${{ matrix.group }} + # RECORD_ALL_CONTENT: 1 + # RECORD_REPLAY: 1 + # RECORD_REPLAY_TEST_METRICS: 1 + # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} - - uses: replayio/action-upload@v0.4.5 - if: always() - with: - api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti - public: true - filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} + # - uses: replayio/action-upload@v0.4.5 + # if: always() + # with: + # api-key: rwk_iKsQnEoQwKd31WAJxgN9ARPFuAlyXlVrDH4uhYpRnti + # public: true + # filter: ${{ 'function($v) { $v.metadata.test.result = "failed" }' }} - name: Upload test trace if: always() From 8e720fbbb81cd61f71ea9def6c7e5e7892a18cf8 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Mon, 21 Nov 2022 14:18:05 -0800 Subject: [PATCH 4/4] fix missing env --- .github/workflows/build_test_deploy.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index 0477dd939bb76..3ad8cc36f014a 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -379,11 +379,11 @@ jobs: - run: node run-tests.js --type e2e --timings -g ${{ matrix.group }}/3 name: Run test/e2e (dev) if: ${{needs.build.outputs.docsChange == 'nope'}} - # env: + env: + NEXT_TEST_MODE: dev # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testDevE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} # RECORD_ALL_CONTENT: 1 # RECORD_REPLAY: 1 - # NEXT_TEST_MODE: dev # RECORD_REPLAY_TEST_METRICS: 1 # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }} @@ -523,11 +523,11 @@ jobs: - run: node run-tests.js --type e2e --timings -g ${{ matrix.group }}/3 name: Run test/e2e (production) if: ${{needs.build.outputs.docsChange == 'nope'}} - # env: + env: + NEXT_TEST_MODE: start # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: testProdE2E / Group ${{ matrix.group }} / Node ${{ matrix.node }} # RECORD_ALL_CONTENT: 1 # RECORD_REPLAY: 1 - # NEXT_TEST_MODE: start # RECORD_REPLAY_TEST_METRICS: 1 # RECORD_REPLAY_WEBHOOK_URL: ${{ secrets.RECORD_REPLAY_WEBHOOK_URL }}