Clean up fs references in the base server #32322

shuding · 2021-12-09T15:12:23Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-12-09T15:23:08Z

Failing test suites

Commit: 3a09248

test/integration/amp-export-validation/test/index.test.js

AMP Validation on Export > should have shown errors during build
AMP Validation on Export > throws error on AMP error
AMP Validation on Export > shows warning and error when throwing error

Expand output

● AMP Validation on Export › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "info  - Checking validity of types...
info  - Creating an optimized production build...
info  - Compiled successfully
info  - Collecting page data...
info  - Generating static pages (0/8)
info  - Generating static pages (2/8)
info  - Generating static pages (4/8)
info  - Generating static pages (6/8)
info  - Generating static pages (8/8)
Amp Validation·
/cat  error  The mandatory attribute 'height' is missing in tag 'amp-video'.  https://amp.dev/documentation/components/amp-video/·
warn  - Detected next.config.js, no exported configuration found. https://nextjs.org/docs/messages/empty-configuration
warn  - The Next.js plugin was not detected in your ESLint configuration. See https://nextjs.org/docs/basic-features/eslint#migrating-existing-config·
> Build error occurred
Error: AMP Validation caused the export to fail. https://nextjs.org/docs/messages/amp-export-validation

  495 |         }
  496 |         if (hadValidationError) {
> 497 |             throw new Error(`AMP Validation caused the export to fail. https://nextjs.org/docs/messages/amp-export-validation`);
      |                   ^
  498 |         }
  499 |         if (renderError) {
  500 |             throw new Error(`Export encountered errors on following paths:\n\t${errorPaths.sort().join('\n\t')}`);

  at ../packages/next/dist/export/index.js:497:19
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:74:20)
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/index.js:996:17
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:74:20)
  at ../async /home/runner/work/next.js/next.js/packages/next/dist/build/index.js:870:13
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:74:20)
  at async Object.build [as default] (../packages/next/dist/build/index.js:82:25)
  "
  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:25:29)

● AMP Validation on Export › throws error on AMP error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "info  - using build directory: /home/runner/work/next.js/next.js/test/integration/amp-export-validation/.next
info  - Copying \"static build\" directory
info  - Launching 1 workers
info  - Exporting (0/3)
info  - Exporting (3/3)
Export successful. Files written to /home/runner/work/next.js/next.js/test/integration/amp-export-validation/out
"

  71 |       `exportPathMap: function(defaultMap) {
  72 |       return {
> 73 |         '/dog': { page: '/dog' },
     |                            ^
  74 |       }
  75 |     },`
  76 |     )

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:73:28)
      at runMicrotasks (<anonymous>)

● AMP Validation on Export › shows warning and error when throwing error

expect(received).toMatch(expected)

Expected pattern: /error.*The parent tag of tag 'img' is 'div', but it can only be 'i-amphtml-sizer-intrinsic'\./
Received string:  "info  - using build directory: /home/runner/work/next.js/next.js/test/integration/amp-export-validation/.next
info  - Copying \"static build\" directory
info  - Launching 1 workers
info  - Exporting (0/3)
info  - Exporting (3/3)
Export successful. Files written to /home/runner/work/next.js/next.js/test/integration/amp-export-validation/out
"

  92 |     }
  93 |   })
> 94 |
     | ^
  95 |   it('shows warning and error when throwing error', async () => {
  96 |     nextConfig.replace(
  97 |       '// exportPathMap',

  at Object.<anonymous> (integration/amp-export-validation/test/index.test.js:94:28)
      at runMicrotasks (<anonymous>)

ijjk · 2021-12-09T15:30:23Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/f783	Change
buildDuration	19.6s	20.1s	⚠️ +560ms
buildDurationCached	3.8s	3.6s	-178ms
nodeModulesSize	351 MB	351 MB	⚠️ +6.42 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	shuding/next.js shu/f783	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.258	3.313	⚠️ +0.06
/ avg req/sec	767.32	754.55	⚠️ -12.77
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.588	1.624	⚠️ +0.04
/error-in-render avg req/sec	1574.25	1539.8	⚠️ -34.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/f783	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.8 kB	28.8 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.7 kB	72.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/f783	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/f783	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.39 kB	2.39 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/f783	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/f783	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/f783	Change
buildDuration	21.6s	21.2s	-303ms
buildDurationCached	3.6s	3.8s	⚠️ +127ms
nodeModulesSize	351 MB	351 MB	⚠️ +6.42 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	shuding/next.js shu/f783	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.359	3.583	⚠️ +0.22
/ avg req/sec	744.37	697.74	⚠️ -46.63
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.507	1.624	⚠️ +0.12
/error-in-render avg req/sec	1659.36	1539.17	⚠️ -120.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/f783	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	29 kB	29 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	73 kB	73 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/f783	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/f783	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.39 kB	2.39 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.75 kB	4.75 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/f783	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/f783	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 3a09248

This PR moves `require` and `fs` usage from the base server to the node server. Closes #32322. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

This PR moves `require` and `fs` usage from the base server to the node server. Closes vercel#32322. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

shuding added 3 commits December 7, 2021 20:26

add next-web-server

ce95f4d

get rid of require

68197c2

image-optimizer

3a09248

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 9, 2021

shuding mentioned this pull request Dec 9, 2021

Switchable server runtime #31506

Closed

15 tasks

javivelasco assigned shuding Dec 16, 2021

shuding mentioned this pull request Jan 12, 2022

Abstract out native filesystem usage from the base server #33226

Merged

10 tasks

kodiakhq bot closed this in #33226 Jan 12, 2022

shuding deleted the shu/f783 branch January 12, 2022 18:46

vercel locked as resolved and limited conversation to collaborators Feb 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up fs references in the base server #32322

Clean up fs references in the base server #32322

shuding commented Dec 9, 2021

ijjk commented Dec 9, 2021

ijjk commented Dec 9, 2021

Clean up fs references in the base server #32322

Clean up fs references in the base server #32322

Conversation

shuding commented Dec 9, 2021

Bug

Feature

Documentation / Examples

ijjk commented Dec 9, 2021

Failing test suites

ijjk commented Dec 9, 2021

Stats from current PR