From 6aae0156a97db7903df874ad0f8635a77443c996 Mon Sep 17 00:00:00 2001 From: Jan Potoms <2109932+Janpot@users.noreply.github.com> Date: Wed, 22 Jul 2020 20:03:31 +0200 Subject: [PATCH 1/6] try cache v2.1.0 --- .github/workflows/build_test_deploy.yml | 16 ++++++++-------- .github/workflows/test_react_next.yml | 4 ++-- errors/no-cache.md | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index 814cd47f071f2..6384cf774c673 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v2 - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* - run: yarn install --frozen-lockfile --check-files - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: cache-build with: path: '.' @@ -25,7 +25,7 @@ jobs: runs-on: ubuntu-latest needs: build steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' @@ -39,7 +39,7 @@ jobs: env: NEXT_TELEMETRY_DISABLED: 1 steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' @@ -59,7 +59,7 @@ jobs: matrix: group: [1, 2, 3, 4, 5, 6] steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' @@ -104,7 +104,7 @@ jobs: BROWSERNAME: 'firefox' NEXT_TELEMETRY_DISABLED: 1 steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' @@ -123,7 +123,7 @@ jobs: BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' @@ -143,7 +143,7 @@ jobs: BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' @@ -157,7 +157,7 @@ jobs: env: NPM_TOKEN: ${{ secrets.NPM_TOKEN }} steps: - - uses: actions/cache@v1 + - uses: actions/cache@v2 id: restore-build with: path: '.' diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index 443b0e25af518..5c28696da2175 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -17,7 +17,7 @@ jobs: # - run: yarn upgrade react@next react-dom@next -W --dev - # - uses: actions/cache@v1 + # - uses: actions/cache@v2 # id: cache-build # with: # path: '.' @@ -35,7 +35,7 @@ jobs: matrix: group: [1, 2, 3, 4, 5, 6] steps: - # - uses: actions/cache@v1 + # - uses: actions/cache@v2 # id: restore-build # with: # path: '.' diff --git a/errors/no-cache.md b/errors/no-cache.md index 8bf18012bbd60..53a632c4f087f 100644 --- a/errors/no-cache.md +++ b/errors/no-cache.md @@ -78,7 +78,7 @@ cache: Using GitHub's [actions/cache](https://github.com/actions/cache), add the following step in your workflow file: ```yaml -uses: actions/cache@v1 +uses: actions/cache@v2 with: path: ${{ github.workspace }}/.next/cache key: ${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json') }} From e18b88fb11080d4aab7344ab1b69ab73198a37c0 Mon Sep 17 00:00:00 2001 From: Jan Potoms <2109932+Janpot@users.noreply.github.com> Date: Wed, 22 Jul 2020 20:11:22 +0200 Subject: [PATCH 2/6] needs to be at start? --- .github/workflows/build_test_deploy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index 6384cf774c673..fb1ee5df1a437 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -13,13 +13,13 @@ jobs: NEXT_TELEMETRY_DISABLED: 1 steps: - uses: actions/checkout@v2 - - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* - - run: yarn install --frozen-lockfile --check-files - uses: actions/cache@v2 id: cache-build with: path: '.' key: ${{ github.sha }} + - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* + - run: yarn install --frozen-lockfile --check-files lint: runs-on: ubuntu-latest From f2519500c23d2ae6b21fb2ec2d037dd572408edb Mon Sep 17 00:00:00 2001 From: Jan Potoms <2109932+Janpot@users.noreply.github.com> Date: Wed, 22 Jul 2020 20:20:38 +0200 Subject: [PATCH 3/6] maybe this --- .github/workflows/build_test_deploy.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index fb1ee5df1a437..ec56f5866227a 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -12,14 +12,14 @@ jobs: env: NEXT_TELEMETRY_DISABLED: 1 steps: + - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* + - run: yarn install --frozen-lockfile --check-files - uses: actions/checkout@v2 - uses: actions/cache@v2 id: cache-build with: - path: '.' + path: './*' key: ${{ github.sha }} - - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* - - run: yarn install --frozen-lockfile --check-files lint: runs-on: ubuntu-latest @@ -28,7 +28,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} - run: yarn lint @@ -42,7 +42,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} - run: ./check-pre-compiled.sh @@ -62,7 +62,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} # TODO: remove after we fix watchpack watching too much @@ -107,7 +107,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} - run: node run-tests.js test/integration/production/test/index.test.js @@ -126,7 +126,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} - run: '[[ -z "$BROWSERSTACK_ACCESS_KEY" ]] && echo "Skipping for PR" || node run-tests.js test/integration/production/test/index.test.js' @@ -146,7 +146,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} - run: '[[ -z "$BROWSERSTACK_ACCESS_KEY" ]] && echo "Skipping for PR" || node run-tests.js test/integration/production-nav/test/index.test.js' @@ -160,7 +160,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: '.' + path: './*' key: ${{ github.sha }} - run: ./publish-release.sh From 2e9cf3d3da99dd72c3ee51db0221e35d8ba15ffa Mon Sep 17 00:00:00 2001 From: Jan Potoms <2109932+Janpot@users.noreply.github.com> Date: Wed, 22 Jul 2020 20:20:58 +0200 Subject: [PATCH 4/6] not this dummy --- .github/workflows/build_test_deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index ec56f5866227a..cca8a042458cd 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -12,9 +12,9 @@ jobs: env: NEXT_TELEMETRY_DISABLED: 1 steps: + - uses: actions/checkout@v2 - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/* - run: yarn install --frozen-lockfile --check-files - - uses: actions/checkout@v2 - uses: actions/cache@v2 id: cache-build with: From 1757db7b0df3536710aa76b8ec4239e849e40383 Mon Sep 17 00:00:00 2001 From: Jan Potoms <2109932+Janpot@users.noreply.github.com> Date: Wed, 22 Jul 2020 20:59:04 +0200 Subject: [PATCH 5/6] Use github.workspace context var --- .github/workflows/build_test_deploy.yml | 16 ++++++++-------- .github/workflows/test_react_next.yml | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index cca8a042458cd..7a3335b4c592c 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/cache@v2 id: cache-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} lint: @@ -28,7 +28,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} - run: yarn lint @@ -42,7 +42,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} - run: ./check-pre-compiled.sh @@ -62,7 +62,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} # TODO: remove after we fix watchpack watching too much @@ -107,7 +107,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} - run: node run-tests.js test/integration/production/test/index.test.js @@ -126,7 +126,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} - run: '[[ -z "$BROWSERSTACK_ACCESS_KEY" ]] && echo "Skipping for PR" || node run-tests.js test/integration/production/test/index.test.js' @@ -146,7 +146,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} - run: '[[ -z "$BROWSERSTACK_ACCESS_KEY" ]] && echo "Skipping for PR" || node run-tests.js test/integration/production-nav/test/index.test.js' @@ -160,7 +160,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: './*' + path: ${{ github.workspace }} key: ${{ github.sha }} - run: ./publish-release.sh diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index 5c28696da2175..af3e862b001f7 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -20,7 +20,7 @@ jobs: # - uses: actions/cache@v2 # id: cache-build # with: - # path: '.' + # path: ${{ github.workspace }} # key: ${{ github.sha }} testAll: @@ -38,7 +38,7 @@ jobs: # - uses: actions/cache@v2 # id: restore-build # with: - # path: '.' + # path: ${{ github.workspace }} # key: ${{ github.sha }} - uses: actions/checkout@v2 From ae543e5a6756ac3ead4a3e98ba21594ed6c599fc Mon Sep 17 00:00:00 2001 From: Jan Potoms <2109932+Janpot@users.noreply.github.com> Date: Wed, 22 Jul 2020 21:03:43 +0200 Subject: [PATCH 6/6] nope --- .github/workflows/build_test_deploy.yml | 16 ++++++++-------- .github/workflows/test_react_next.yml | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml index 7a3335b4c592c..bd74c76cff084 100644 --- a/.github/workflows/build_test_deploy.yml +++ b/.github/workflows/build_test_deploy.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/cache@v2 id: cache-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} lint: @@ -28,7 +28,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} - run: yarn lint @@ -42,7 +42,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} - run: ./check-pre-compiled.sh @@ -62,7 +62,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} # TODO: remove after we fix watchpack watching too much @@ -107,7 +107,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} - run: node run-tests.js test/integration/production/test/index.test.js @@ -126,7 +126,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} - run: '[[ -z "$BROWSERSTACK_ACCESS_KEY" ]] && echo "Skipping for PR" || node run-tests.js test/integration/production/test/index.test.js' @@ -146,7 +146,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} - run: '[[ -z "$BROWSERSTACK_ACCESS_KEY" ]] && echo "Skipping for PR" || node run-tests.js test/integration/production-nav/test/index.test.js' @@ -160,7 +160,7 @@ jobs: - uses: actions/cache@v2 id: restore-build with: - path: ${{ github.workspace }} + path: ./* key: ${{ github.sha }} - run: ./publish-release.sh diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index af3e862b001f7..9eb76fe8ee434 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -20,7 +20,7 @@ jobs: # - uses: actions/cache@v2 # id: cache-build # with: - # path: ${{ github.workspace }} + # path: ./* # key: ${{ github.sha }} testAll: @@ -38,7 +38,7 @@ jobs: # - uses: actions/cache@v2 # id: restore-build # with: - # path: ${{ github.workspace }} + # path: ./* # key: ${{ github.sha }} - uses: actions/checkout@v2