Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not duplicate compilation errors #15299

Merged
merged 5 commits into from
Jul 19, 2020
Merged

Do not duplicate compilation errors #15299

merged 5 commits into from
Jul 19, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Jul 19, 2020

This pull request removes the duplication of compile errors.

Next.js meticulously controls the console output during a compilation error to give the user a very clear indication of the issue and where to fix it.

This code path would add console noise and obscure the real issue by not running the error through our appropriate human-friendly output.

Meaning, the user would see this error, without the source file:

Error: Syntax error: Unexpected token, expected ";"

  3 | 
  4 | export default function App({ Component, pageProps }) {
> 5 |   return <Component {...pageProps} />!;
    |                                      ^
  6 | }
  7 | 
    at getBabelError (/Users/joe/Documents/Blog/www/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/parseBabel.js:4:91)
    at getModuleBuildError (/Users/joe/Documents/Blog/www/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/webpackModuleError.js:1:2469)
    at /Users/joe/Documents/Blog/www/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/index.js:1:549
    at Array.map (<anonymous>)
    at /Users/joe/Documents/Blog/www/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/index.js:1:478
    at SyncHook.eval [as call] (eval at create (/Users/joe/Documents/Blog/www/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
    at SyncHook.lazyCompileHook (/Users/joe/Documents/Blog/www/node_modules/tapable/lib/Hook.js:154:20)
    at Compilation.seal (/Users/joe/Documents/Blog/www/node_modules/webpack/lib/Compilation.js:1284:19)
    at /Users/joe/Documents/Blog/www/node_modules/webpack/lib/Compiler.js:675:18
    at /Users/joe/Documents/Blog/www/node_modules/webpack/lib/Compilation.js:1261:4

This pull request ensures the last thing logged in the console is the following code:

error - ./pages/_app.js:5:37
Syntax error: Unexpected token, expected ";"

  3 | 
  4 | export default function App({ Component, pageProps }) {
> 5 |   return <Component {...pageProps} />!;
    |                                      ^
  6 | }
  7 |

Fixes #15071

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 11.8s 11.5s -276ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.995 1.845 -0.15
/ avg req/sec 1253.17 1354.76 +101.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.379 1.47 ⚠️ +0.09
/error-in-render avg req/sec 1813.34 1701.08 ⚠️ -112.26
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 12.5s 12.6s ⚠️ +77ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 01d80e3

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 14.4s 14.4s -22ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.499 2.366 -0.13
/ avg req/sec 1000.27 1056.68 +56.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.588 1.641 ⚠️ +0.05
/error-in-render avg req/sec 1574.08 1523.41 ⚠️ -50.67
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 13.4s 12.6s -795ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 121ebf8

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Failing test suites

Commit: 121ebf8

test/integration/no-duplicate-compile-error/test/index.test.js

  • no duplicate compile error output > show not show compile error on page refresh
Expand output

● no duplicate compile error output › show not show compile error on page refresh

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 3

  54 |     await browser.waitForElementByCss('#a')
  55 | 
> 56 |     expect((stdout.match(/Unexpected token/g) || []).length).toBe(1)
     |                                                              ^
  57 |     expect(stderr).toBe('')
  58 | 
  59 |     await killApp(app)

  at Object.<anonymous> (integration/no-duplicate-compile-error/test/index.test.js:56:62)
      at runMicrotasks (<anonymous>)

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 11.8s 10.9s -817ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.957 1.855 -0.1
/ avg req/sec 1277.35 1347.65 +70.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.138 1.133 0
/error-in-render avg req/sec 2196.98 2205.71 +8.73
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 12.1s 12.4s ⚠️ +316ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 9855709

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Failing test suites

Commit: 9855709

test/integration/no-duplicate-compile-error/test/index.test.js

  • no duplicate compile error output > show not show compile error on page refresh
Expand output

● no duplicate compile error output › show not show compile error on page refresh

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  54 |     await browser.waitForElementByCss('#a')
  55 | 
> 56 |     expect((stdout.match(/Unexpected token/g) || []).length).toBe(1)
     |                                                              ^
  57 |     expect(stderr).toBe('')
  58 | 
  59 |     await killApp(app)

  at Object.<anonymous> (integration/no-duplicate-compile-error/test/index.test.js:56:62)
      at runMicrotasks (<anonymous>)

timneutkens
timneutkens previously approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 14.1s 13.9s -258ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.349 2.331 -0.02
/ avg req/sec 1064.09 1072.58 +8.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.524 1.555 ⚠️ +0.03
/error-in-render avg req/sec 1640.43 1607.27 ⚠️ -33.16
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 15.8s 14.7s -1.2s
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 8515bca

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Failing test suites

Commit: 8515bca

test/integration/no-duplicate-compile-error/test/index.test.js

  • no duplicate compile error output > show not show compile error on page refresh
Expand output

● no duplicate compile error output › show not show compile error on page refresh

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  57 |     await browser.waitForElementByCss('#a')
  58 | 
> 59 |     expect((stdout.match(/Unexpected token/g) || []).length).toBe(1)
     |                                                              ^
  60 |     expect(stderr).toBe('')
  61 | 
  62 |     await killApp(app)

  at Object.<anonymous> (integration/no-duplicate-compile-error/test/index.test.js:59:62)

@ijjk
Copy link
Member

ijjk commented Jul 19, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 13.1s 13.4s ⚠️ +260ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.232 2.3 ⚠️ +0.07
/ avg req/sec 1120.02 1086.86 ⚠️ -33.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.484 1.505 ⚠️ +0.02
/error-in-render avg req/sec 1684.75 1661.63 ⚠️ -23.12
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
buildDuration 14.5s 14.4s -75ms
nodeModulesSize 66.5 MB 66.5 MB ⚠️ +287 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..db49.js gzip 9.7 kB 9.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-37681a1..8579.js gzip 6.72 kB 6.72 kB ✓
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 87.1 kB 87.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
677f882d2ed8..dule.js gzip 6.1 kB 6.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-a93d67d..dule.js gzip 5.79 kB 5.79 kB ✓
polyfills-05..dule.js gzip 30.8 kB 30.8 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 82.6 kB 82.6 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-8e69b..8695.js gzip 3.41 kB 3.41 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-ddd176e..5566.js gzip 1.29 kB 1.29 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.66 kB 7.66 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-663e6..dule.js gzip 2.24 kB 2.24 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-69bc264..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.29 kB 5.29 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_buildManifest.js gzip 275 B 275 B ✓
_buildManife..dule.js gzip 281 B 281 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/dedupe-errors Change
_error.js 881 kB 881 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 882 kB 882 kB ✓
link.js 923 kB 923 kB ✓
routerDirect.js 917 kB 917 kB ✓
withRouter.js 917 kB 917 kB ✓
Overall change 4.53 MB 4.53 MB ✓
Commit: 137a23a

@Timer Timer merged commit 13a971c into vercel:canary Jul 19, 2020
@Timer Timer deleted the hotfix/dedupe-errors branch July 19, 2020 18:09
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing Next.js build output
3 participants
@Timer @ijjk @timneutkens