Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next-server.d.ts: TS7033: Property '_isLikeServerless' implicitly has type 'any' #9996

Closed
albreax opened this issue Jan 8, 2020 · 5 comments
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@albreax
Copy link

albreax commented Jan 8, 2020

private get _isLikeServerless() in next-server/server/next-server.d.ts has noch return type. That cause following issue in typescript projects with "noImplicitAny": true, configuration.

ERROR in [at-loader] ./node_modules/next/dist/next-server/server/next-server.d.ts:114:17 
    TS7033: Property '_isLikeServerless' implicitly has type 'any', because its get accessor lacks a return type annotation.
@Timer Timer added good first issue Easy to fix issues, good for newcomers help wanted labels Jan 8, 2020
@Timer
Copy link
Member

Timer commented Jan 8, 2020

I've never seen this before, and don't know how to fix. Feel free to send a PR.

@timneutkens
Copy link
Member

Would help if you used the issue template and provided a full reproduction.

@ssong
Copy link
Contributor

ssong commented Jan 8, 2020

@albreax I think this may be a Typescript version issue as Typescript versions <3.7 were incorrectly running the "noImplicitAny" check on private getters. Detailed in the following threads.

microsoft/TypeScript#33894 (comment)

aws/aws-cdk#5497

@albreax
Copy link
Author

albreax commented Jan 9, 2020

@ssong thank you, that helped.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants