Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next dev --turbo does not respect pageExtensions for custom App/Document #59264

Closed
1 task done
miselin opened this issue Dec 4, 2023 · 1 comment · Fixed by #60789
Closed
1 task done

next dev --turbo does not respect pageExtensions for custom App/Document #59264

miselin opened this issue Dec 4, 2023 · 1 comment · Fixed by #60789
Labels
bug Issue was opened via the bug report template. linear: turbopack Confirmed issue that is tracked by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.

Comments

@miselin
Copy link

miselin commented Dec 4, 2023

Link to the code that reproduces this issue

https://github.com/miselin/next-turbo-pageextensions-repro

To Reproduce

  1. npm run dev
  2. Visit http://localhost:3000
  3. "hi from _app" and "hi from _document" should be visible (DOM IDs app-ran-repro and document-ran-repro)
  4. Terminate the dev server
  5. npm run dev:turbo
  6. Visit http://localhost:3000
  7. The "hi from ..." tags are no longer visible in the rendered HTML. A hydration error is also shown from the MyApp component.

Current vs. Expected behavior

Currently, running with --turbo requires _app.tsx and _document.tsx regardless of the value of pageExtensions.

I expect these to also respect pageExtensions as they do when --turbo is not provided.

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 22.6.0: Thu Nov  2 07:43:57 PDT 2023; root:xnu-8796.141.3.701.17~6/RELEASE_ARM64_T6000
Binaries:
  Node: 20.10.0
  npm: 10.2.3
  Yarn: 1.22.19
  pnpm: 8.11.0
Relevant Packages:
  next: 14.0.4-canary.39
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.1.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Turbopack (--turbo)

Additional context

No response

PACK-2085

@miselin miselin added the bug Issue was opened via the bug report template. label Dec 4, 2023
@github-actions github-actions bot added the Turbopack Related to Turbopack with Next.js. label Dec 4, 2023
@ForsakenHarmony ForsakenHarmony added the linear: turbopack Confirmed issue that is tracked by the Turbopack team. label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot added the locked label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. linear: turbopack Confirmed issue that is tracked by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants