not-found path doesn't include / derivate layout

[agustinusnathaniel]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000
    Binaries:
      Node: 16.14.0
      npm: 9.7.2
      Yarn: 1.22.19
      pnpm: 8.3.0
    Relevant Packages:
      next: 13.4.10
      eslint-config-next: 13.4.10
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A

Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

Link to the code that reproduces this issue or a replay of the bug

https://vercel.com/sozonome/nextjs-reproduce-not-found-issue

To Reproduce

Steps to Reproduce

1. Install next v13.4.10 or later (including canary version)
2. Add not-found.js/ts file
3. Run next dev (also reproduced in build version)
4. Open any pathname that are not defined (that should produce 404 / not-found error)

Actual Result

Will show 404 / not-found page, but doesn't include what's defined/composed in layout.js/ts

Expected Result

Will show 404 / not-found page and include what's defined/composed in layout.js/ts

Describe the Bug

app/not-found doesn't include layout since v13.4.10

not-found not include layout samples:

• next v13.4.10:
  • commit: agustinusnathaniel/nextjs-reproduce-not-found-issue@640c5f6#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R29
  • deployment: https://nextjs-reproduce-not-found-issue-925964yy0-sozonome.vercel.app/aa
• next v13.4.11-canary.0:
  • commit: agustinusnathaniel/nextjs-reproduce-not-found-issue@3f7e981#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R29
  • deployment: https://nextjs-reproduce-not-found-issue-kyjpm7pnw-sozonome.vercel.app/aa

Expected Behavior

app/not-found include layout (it has been that way before v13.4.10, and there's no update in the documentation of next.js that says otherwise)

• next v13.4.9 not-found sample (in this version, not-found still include layout):
  • commit: agustinusnathaniel/nextjs-reproduce-not-found-issue@82c3ca1#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R29
  • deployment: https://nextjs-reproduce-not-found-issue-o82nnjrwr-sozonome.vercel.app/aa

Which browser are you using? (if relevant)

Brave v1.52.130

How are you deploying your application? (if relevant)

Vercel

[huozhi]

Fixed by #52790

[agustinusnathaniel]

But the fix is reverted before release v13.4.11 ?
#52977

[Galanthus]

Fixed by #52790

Sorry to say, but actually it's not fixed with the latest version.

[karlhorky]

It looks like @huozhi re-landed the fix in #52985 (reviewed by @ijjk and published in [email protected])

[Galanthus]

It looks like @huozhi re-landed the fix in #52985 (reviewed by @ijjk and published in [email protected])

Having a custom not-fount.tsx/jsx won’t load id notFound is fired. This works fine in 13.4.9

[agustinusnathaniel]

I think it's already fixed in [email protected]

[Galanthus]

I think it's already fixed in [email protected]

that's what you Think.. but it is not. Easy closing?

[github-actions]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.